From: Phillip Wood <phillip.wood123@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Bug in unused.cocci?
Date: Thu, 11 May 2023 10:16:21 +0100 [thread overview]
Message-ID: <5720a23e-6ac0-9a6d-3d05-4e0f34bc0589@gmail.com> (raw)
The CI static analysis job for my unit test framework patch[1] fails[2] with
Coccinelle suggests the following changes in
'contrib/coccinelle/ALL.cocci.patch':
diff -u -p a/t/unit-tests/t-strbuf.c b/t/unit-tests/t-strbuf.c
--- a/t/unit-tests/t-strbuf.c
+++ b/t/unit-tests/t-strbuf.c
@@ -27,13 +27,9 @@ static void t_static_init(void)
static void t_dynamic_init(void)
{
- struct strbuf buf;
-
- strbuf_init(&buf, 1024);
check_uint(buf.len, ==, 0);
check_uint(buf.alloc, >=, 1024);
check_char(buf.buf[0], ==, '\0');
- strbuf_release(&buf);
}
static void t_addch(struct strbuf *buf, void *data)
error: Coccinelle suggested some changes
I think this is due to a bug in unused.cocci. I'm not sure what is going
wrong and admittedly we're unlikely to see code where an strbuf is
initialized and then used it without calling any of the strbuf_*
functions within our main codebase but it would be nice if the rule
could handle this.
Best Wishes
Phillip
[1]
https://lore.kernel.org/git/c902a166-98ce-afba-93f2-ea6027557176@gmail.com/
[2]
https://github.com/phillipwood/git/actions/runs/4938207776/jobs/8827751328
next reply other threads:[~2023-05-11 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 9:16 Phillip Wood [this message]
2023-05-11 14:55 ` Bug in unused.cocci? Taylor Blau
2023-05-12 15:07 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720a23e-6ac0-9a6d-3d05-4e0f34bc0589@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).