From: "Rubén Justo" <rjusto@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2] launch_editor: waiting message on error
Date: Wed, 10 Apr 2024 01:38:10 +0200 [thread overview]
Message-ID: <54dcd4f1-5a79-47ba-9650-7115b7170a84@gmail.com> (raw)
In-Reply-To: <xmqq4jcb495u.fsf@gitster.g>
On Mon, Apr 08, 2024 at 06:27:57PM -0700, Junio C Hamano wrote:
> I wonder if we can just call term_clear_line()
> regardless of the value of ret. Either case, the waiting is already
> over and in the error case, we show another message after it.
My concern is that perhaps term_clear_line() might clear some useful
information for the user. Although I am not sure that this concern is
sensible.
Stepping back a bit, how painful it would be to drop the
term_clear_line() and start using advice_if_enabled() here?
This is what I'm thinking about now.
$ GIT_EDITOR=false git commit -a
hint: A-good-explanation-to-say-we-run-'editor'
hint: Disable this message with "git config advice.waitingForEditor false"
error: There was a problem with the editor 'false'.
Please supply the message using either -m or -F option.
> There is another error message when we fail to start the editor.
> Doesn't that codepath have the same problem?
Of course.
My itch is:
$ GIT_EDITOR=false git commit -a
hint: Waiting for your editor to close the file... error: There was a problem with the editor 'false'.
Please supply the message using either -m or -F option.
But, yes, while we're here we can also fix:
$ GIT_EDITOR=falso git commit -a
hint: Waiting for your editor to close the file... error: cannot run falso: No such file or directory
error: unable to start editor 'falso'
Please supply the message using either -m or -F option.
next prev parent reply other threads:[~2024-04-09 23:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 21:02 [PATCH] launch_editor: waiting message on error Rubén Justo
2024-04-08 21:07 ` Rubén Justo
2024-04-08 23:09 ` [PATCH v2] " Rubén Justo
2024-04-09 1:27 ` Junio C Hamano
2024-04-09 23:38 ` Rubén Justo [this message]
2024-04-10 15:44 ` Junio C Hamano
2024-04-11 23:18 ` Rubén Justo
2024-04-12 15:46 ` Junio C Hamano
2024-04-12 17:03 ` Rubén Justo
2024-04-12 17:35 ` Junio C Hamano
2024-04-12 18:24 ` Rubén Justo
2024-04-12 17:05 ` [PATCH v3 0/2] launch_editor: waiting message Rubén Justo
2024-04-12 17:15 ` [PATCH v3 1/2] launch_editor: waiting for editor message Rubén Justo
2024-04-12 17:24 ` rsbecker
2024-04-12 17:37 ` Rubén Justo
2024-04-12 17:47 ` rsbecker
2024-04-13 15:06 ` Phillip Wood
2024-04-12 17:15 ` [PATCH v3 2/2] launch_editor: waiting message on error Rubén Justo
2024-04-13 15:09 ` Phillip Wood
2024-04-14 7:23 ` Rubén Justo
2024-04-14 7:39 ` [PATCH v4] " Rubén Justo
2024-04-15 14:05 ` Phillip Wood
2024-04-15 17:03 ` Rubén Justo
2024-04-15 17:20 ` Junio C Hamano
2024-04-15 17:07 ` Rubén Justo
2024-04-15 18:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54dcd4f1-5a79-47ba-9650-7115b7170a84@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).