Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Dragan Simic <>
To: Junio C Hamano <>
Subject: Re: [PATCH v6 2/2] send-email: make it easy to discern the messages for each patch
Date: Sun, 28 Apr 2024 05:03:47 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <xmqqo79u4qlc.fsf@gitster.g>

On 2024-04-27 20:18, Junio C Hamano wrote:
> Junio C Hamano <> writes:
>> Well, v1 and v3-v5 saw comments only from me.  There was a comment
>> on v2 by Kristoffer Haugsbakk about phrasing in proposed log
>> message.  v6 had Eric's "Meh, either way".
> FWIW, somewhere between v2 and v3 may have been a good place to
> stop.
> "After calling send_message(), give an extra blank line before the
> next message" was extremely easy to see why it was a good idea.
> Mixing it with "oh, during the process of a single invocation of
> send_message(), there may be other places that want extra blank
> lines" made the changes less focused.  Personally I lost interest
> in the series at around that point.

Thank you for your additional feedback.

Admittedly, the whole endeavor could have been handled better from
my side, with fewer "oh, let's do it differently and a bit better"
iterations that inevitably made the whole thing harder to follow and
become interested with.

However, I find improving the way "git send-mail" works rather 
because if it bothers me, it must be bothering other people, who may
simply not be on the mailing list.  As we know, a lot of people quite
regularly complain through different channels about sending patches by
email being not user-friendly, which should make any attempts to make
it more user-friendly quite important, if you agree.

I have some more plans for improving "git send-mail" and adding some new
features, but I need to get everything into the final shape I'm pretty
much 100% satisfied with, both from the design and the implementation
standpoints, before sending the patches over.

      reply	other threads:[~2024-04-28  3:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10  7:01 [PATCH v6 0/2] send-email: make produced outputs more readable Dragan Simic
2024-04-10  7:01 ` [PATCH v6 1/2] send-email: move newline characters out of a few translatable strings Dragan Simic
2024-04-10 16:12   ` Junio C Hamano
2024-04-13  6:12     ` Dragan Simic
2024-04-10  7:01 ` [PATCH v6 2/2] send-email: make it easy to discern the messages for each patch Dragan Simic
2024-04-10 16:28   ` Junio C Hamano
2024-04-10 22:59     ` Eric Sunshine
2024-04-13  6:10       ` Dragan Simic
2024-04-13  6:27     ` Dragan Simic
2024-04-27 17:27       ` Dragan Simic
2024-04-27 17:41         ` Junio C Hamano
2024-04-27 17:49           ` Dragan Simic
2024-04-27 18:06             ` Junio C Hamano
2024-04-27 18:18               ` Junio C Hamano
2024-04-28  3:03                 ` Dragan Simic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).