Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Philip Oakley <philipoakley@iee.email>
To: Zhang Yi <18994118902@163.com>, git@vger.kernel.org
Cc: v.garg.work@gmail.com
Subject: Re: [GSOC] [PATCH v2 3/3] t9700:delete whitespaces after redirect operators
Date: Fri, 24 Feb 2023 11:20:22 +0000	[thread overview]
Message-ID: <33f15034-4271-cc38-8162-1eadab392552@iee.email> (raw)
In-Reply-To: <20230224013413.1969003-4-18994118902@163.com>

On 24/02/2023 01:34, Zhang Yi wrote:
> There are whitespaces after redirect operators,which is a deprecated

micro-nit: space after comma, before "which".

Philip
> style.
>
> Delete whitespaces after redirect operators.
>
> Signed-off-by: Zhang Yi <18994118902@163.com>
> ---
>  t/t9700-perl-git.sh | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh
> index 671875a3fc..ccc8212d73 100755
> --- a/t/t9700-perl-git.sh
> +++ b/t/t9700-perl-git.sh
> @@ -14,20 +14,20 @@ skip_all_if_no_Test_More
>  # set up test repository
>  
>  test_expect_success 'set up test repository' '
> -	echo "test file 1" > file1 &&
> -	echo "test file 2" > file2 &&
> +	echo "test file 1" >file1 &&
> +	echo "test file 2" >file2 &&
>  	mkdir directory1 &&
> -	echo "in directory1" >> directory1/file &&
> +	echo "in directory1" >>directory1/file &&
>  	mkdir directory2 &&
> -	echo "in directory2" >> directory2/file &&
> +	echo "in directory2" >>directory2/file &&
>  	git add . &&
>  	git commit -m "first commit" &&
>  
> -	echo "new file in subdir 2" > directory2/file2 &&
> +	echo "new file in subdir 2" >directory2/file2 &&
>  	git add . &&
>  	git commit -m "commit in directory2" &&
>  
> -	echo "changed file 1" > file1 &&
> +	echo "changed file 1" >file1 &&
>  	git commit -a -m "second commit" &&
>  
>  	git config --add color.test.slot1 green &&


  reply	other threads:[~2023-02-24 11:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22  4:07 [GSOC] [PATCH v1 0/2] Modernize t9700 test script Zhang Yi
2023-02-22  4:07 ` [GSOC] [PATCH v1 1/2] Fix title style Zhang Yi
2023-02-22  7:13   ` Vivan Garg
2023-02-22  4:07 ` [GSOC] [PATCH v1 2/2] Change indents to TAB Zhang Yi
2023-02-22  7:24   ` Vivan Garg
2023-02-22  7:09 ` [GSOC] [PATCH v1 0/2] Modernize t9700 test script Vivan Garg
2023-02-24  1:34   ` [GSOC] [PATCH v2 0/3] t9700:moderizen test scripts Zhang Yi
2023-02-24  1:34     ` [GSOC] [PATCH v2 1/3] t9700:fix title style Zhang Yi
2023-02-24  1:34     ` [GSOC] [PATCH v2 2/3] t9700:change indents to TAB Zhang Yi
2023-02-24  1:34     ` [GSOC] [PATCH v2 3/3] t9700:delete whitespaces after redirect operators Zhang Yi
2023-02-24 11:20       ` Philip Oakley [this message]
2023-02-24  2:49     ` [GSOC] [PATCH v2 0/3] t9700:moderizen test scripts Junio C Hamano
2023-02-24  3:31       ` Zhang Yi
2023-02-25  1:30   ` [GSOC] [PATCH v3 1/1] t9700: modernize " Zhang Yi
  -- strict thread matches above, loose matches on Subject: below --
2023-02-23 14:15 [GSOC] [PATCH 0/3] t9700:moderizen " Zhang Yi
2023-02-23 14:15 ` [GSOC] [PATCH v2 3/3] t9700:delete whitespaces after redirect operators Zhang Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33f15034-4271-cc38-8162-1eadab392552@iee.email \
    --to=philipoakley@iee.email \
    --cc=18994118902@163.com \
    --cc=git@vger.kernel.org \
    --cc=v.garg.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).