From: "René Scharfe" <l.s.r@web.de>
To: rsbecker@nexbridge.com, git@vger.kernel.org
Subject: Re: [BUG] Git 2.38.0-rc1 t1800 message text comparison
Date: Mon, 22 May 2023 22:39:20 +0200 [thread overview]
Message-ID: <2e3be2e9-191d-fbfd-54c6-a3958e35637c@web.de> (raw)
In-Reply-To: <013701d90f80$692ba9c0$3b82fd40$@nexbridge.com>
Am 14.12.22 um 06:53 schrieb rsbecker@nexbridge.com:
> On September 23, 2022 4:43 PM, I wrote:
>> On September 22, 2022 3:03 PM, I wrote:
>>> On September 22, 2022 3:02 PM, I wrote:
>>>> Rc1 is looking good except for this test.
>>>>
>>>> We get a diff as follows:
>>>>
>>>> -fatal: cannot run bad-hooks/test-hook: ...
>>>> +fatal: cannot exec 'bad-hooks/test-hook': Permission denied
>>>>
>>>> It looks like the pattern
>>>> sed -e s/test-hook: .*/test-hook: .../
>>>>
>>>> needs to be a bit extended. Adding
>>>>
>>>> sed -e s/exec/run/ | send -e s/["']//g
>>>>
>>>> might help clear off the other noise.
>>
>> A patch that might work is as follows:
>>
>> diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh index 43fcb7c0bf..9a723631a2
>> 100755
>> --- a/t/t1800-hook.sh
>> +++ b/t/t1800-hook.sh
>> @@ -173,7 +173,10 @@ test_expect_success 'git hook run a hook with a bad
>> shebang' '
>> -c core.hooksPath=bad-hooks \
>> hook run test-hook >out 2>err &&
>> test_must_be_empty out &&
>> - sed -e "s/test-hook: .*/test-hook: .../" <err >actual &&
>> + quot=`echo "\047"` &&
>> + sed -e "s/exec/run/" <err | \
>> + sed -e "s/$quot//g" | \
>> + sed -e "s/test-hook: .*/test-hook: .../" >actual &&
>> test_cmp expect actual
>> '
>>
>> This does not require setting up a prerequisite for NonStop and the
> technique
>> might make the MING code easier but adding a change from spawn to run.
>
> This is still broken on NonStop. Is there any hope of a resolution?
So trying to execute an executable file consisting only of the line
"#!/bad/path/no/spaces" causes NonStop to report "Permission denied"?
That message text belongs to error code EACCES, not to EPERM ("Operation
not permitted"), right?
POSIX allows execve to return EACCES if the file to execute is not a
regular file and executing that file type is not supported or if
permissions are missing to one of its path components.
Either you have something called /bad that is not a regular file (e.g. a
directory) -- then it's just a matter of changing the test to use a
different supposedly non-existing filename, perhaps by creating and
deleting a temporary file for just that purpose.
Or NonStop correctly returns ENOEXEC on the first execve(2) call in
run-command.c and returns ENOACCES on the fallback with SHELL_PATH
(default value /usr/coreutils/bin/bash), because you are not allowed to
execute that shell. Then SHELL_PATH needs to be corrected.
Or valid shells need to be placed in some kind of allow list to be
accepted in #!-lines, lest NonStop returns ENOACCES on them. Or NonStop
is simply reporting a bogus error code for some reason. In those cases
you probably need an execve) compat/ wrapper that corrects the error
code.
Or I'm missing something here, which is a relatively safe bet. Anyway,
depending on the cause of the "Permission denied" message, loosening the
textual comparison in the test might not be enough. There may not be a
point for end users to distinguish between "exec" vs. "run", but the
silent_exec_failure feature of run-command depends on the error code
being ENOENT.
René
next prev parent reply other threads:[~2023-05-22 20:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 19:01 [BUG] Git 2.28.0-rc1 t1800 message text comparison rsbecker
2022-09-22 19:02 ` [BUG] Git 2.38.0-rc1 " rsbecker
2022-09-23 20:43 ` rsbecker
2022-12-14 5:53 ` rsbecker
2023-05-22 20:39 ` René Scharfe [this message]
2023-05-22 20:49 ` rsbecker
2023-05-22 21:13 ` rsbecker
2023-06-04 12:13 ` René Scharfe
2023-06-04 20:55 ` René Scharfe
2023-06-06 0:31 ` Junio C Hamano
2023-06-10 14:51 ` [PATCH 1/2] t1800: loosen matching of error message for bad shebang René Scharfe
2023-06-12 18:01 ` Junio C Hamano
2023-06-10 14:51 ` [PATCH 2/2] run-command: report exec error even on ENOENT René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e3be2e9-191d-fbfd-54c6-a3958e35637c@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).