From: Paul Smith <psmith@gnu.org>
To: git@vger.kernel.org
Subject: Re: [PATCH] Makefile(s): avoid recipe prefix in conditional statements
Date: Tue, 09 Apr 2024 16:41:56 -0400 [thread overview]
Message-ID: <2b392b30614abd9a110515448853aa43eac42d8b.camel@gnu.org> (raw)
In-Reply-To: <xmqqh6gb5szm.fsf@gitster.g>
On Mon, 2024-04-08 at 16:34 -0700, Junio C Hamano wrote:
> I am not sure what benefits are gained by the existing users with
> this change to ease fixing some parser bug (I didn't bother to see
> your bug tracker) so I cannot judge if the benefit outweighs the
> cost of them all having to scramble and adjust to the new world
> order.
Just to point out that it's actually unusual (in my experience) for
makefiles to use TAB as indentation. There are so many situations
where this comes back to bite you (see my other emails) that people
simply don't do it.
I realize Git and Linux (using Linus's coding style) are committed to
each-TAB-is-one-indentation-level, even insofar as using it inside
makefiles not just C code, but they are outliers IME.
So I'm not sure I'm ready to concede (yet) that the "cost of them all"
is actually very wide. Certainly two projects as popular as Git and
Linux with this problem are very concerning.
next prev parent reply other threads:[~2024-04-09 20:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 10:44 Makefiles are broken as of GNU Make commit 07fcee35f058a876447c8a021f9eb1943f902534 Dario Gjorgjevski
2024-04-08 15:51 ` [PATCH] Makefile(s): avoid recipe prefix in conditional statements Taylor Blau
2024-04-08 21:41 ` Junio C Hamano
2024-04-08 23:24 ` Paul Smith
2024-04-08 23:34 ` Junio C Hamano
2024-04-09 20:41 ` Paul Smith [this message]
2024-04-08 23:44 ` Junio C Hamano
2024-04-09 20:42 ` Paul Smith
2024-04-09 21:23 ` Junio C Hamano
2024-04-09 0:04 ` Jeff King
2024-04-09 0:17 ` Jeff King
2024-04-09 20:44 ` Paul Smith
2024-04-08 23:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b392b30614abd9a110515448853aa43eac42d8b.camel@gnu.org \
--to=psmith@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).