From: Derrick Stolee <derrickstolee@github.com>
To: Ronan Pigott <ronan@rjp.ie>, git@vger.kernel.org
Cc: "Jeff King" <peff@peff.net>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Clement Moyroud" <clement.moyroud@gmail.com>,
"Alex Henrie" <alexhenrie24@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Thomas Ackermann" <th.acker@arcor.de>
Subject: Re: [PATCH 2/2] maintenance: add option to register in a specific config
Date: Mon, 7 Nov 2022 15:49:28 -0500 [thread overview]
Message-ID: <22a74e0f-f389-7b9c-f2cc-b3581c246c75@github.com> (raw)
In-Reply-To: <20221105184532.457043-3-ronan@rjp.ie>
On 11/5/22 2:45 PM, Ronan Pigott wrote:
> maintenance register currently records the maintenance repo exclusively
> within the user's global configuration, but other configuration files
> may be relevant when running maintenance if they are included from the
> global config. This option allows the user to choose where maintenance
> repos are recorded.
Taylor already provided most of the feedback that I would have given.
> static char const * const builtin_maintenance_register_usage[] = {
> - "git maintenance register",
> + "git maintenance register [--config <file>]",
The only recommendation I have remaining is to rename this option to
`--config-file=<file>` since it is unclear from just "--config" if it
is a config _file_ or a config _key_.
Thanks,
-Stolee
prev parent reply other threads:[~2022-11-07 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 18:45 [PATCH 0/2] git-maintenance quality-of-life improvements Ronan Pigott
2022-11-05 18:45 ` [PATCH 1/2] for-each-repo: interpolate repo path arguments Ronan Pigott
2022-11-06 0:30 ` Taylor Blau
2022-11-07 20:46 ` Derrick Stolee
2022-11-05 18:45 ` [PATCH 2/2] maintenance: add option to register in a specific config Ronan Pigott
2022-11-06 0:28 ` Taylor Blau
2022-11-06 0:42 ` Taylor Blau
2022-11-07 20:49 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22a74e0f-f389-7b9c-f2cc-b3581c246c75@github.com \
--to=derrickstolee@github.com \
--cc=alexhenrie24@gmail.com \
--cc=clement.moyroud@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=ronan@rjp.ie \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
--cc=th.acker@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).