From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kyle Meyer <kyle@kyleam.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] send-email: relay '-v N' to format-patch
Date: Mon, 28 Nov 2022 13:34:32 +0100 [thread overview]
Message-ID: <221128.86v8mzl0bh.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqzgcd9ok2.fsf@gitster.g>
On Sun, Nov 27 2022, Junio C Hamano wrote:
> Kyle Meyer <kyle@kyleam.com> writes:
>
>> Here's a patch handling the -v case. I don't plan on working on a more
>> complete fix for the other cases (as I mentioned before, I don't use
>> send-email to drive format-patch), but in my opinion the -v fix by
>> itself is still valuable.
>
> Yup, I think it is a good place to stop for the first patch. Other
> people can add more when they discover the need, and anything more
> complex [*] is probably not worth the effort, I would think.
>
> Side note: [*] we could imagine running "git format-patch -h"
> (or a new variant of it), parse its output and populate the
> %options dynamically, for example.
>
> Will queue. Thanks.
This is just a comment on the #leftoverbits: I've looked at this option
parsing in "git-send-email" before, and IMO the right long-term fix is
to split out the *.perl code into a "git send-email--helper", and do the
option parsing in C using our parse_options().
Some of it will be a bit of a hassle, but it should be much easier after
8de2e2e41b2 (Merge branch 'ab/send-email-optim', 2021-07-22) (and the
subsquent regression fix).
next prev parent reply other threads:[~2022-11-28 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 2:00 [PATCH] send-email: disable option auto-abbreviation Kyle Meyer
2022-11-25 7:11 ` Junio C Hamano
2022-11-25 17:31 ` Kyle Meyer
2022-11-26 20:21 ` [PATCH v2] send-email: relay '-v N' to format-patch Kyle Meyer
2022-11-27 1:25 ` Junio C Hamano
2022-11-28 12:34 ` Ævar Arnfjörð Bjarmason [this message]
2022-11-28 9:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221128.86v8mzl0bh.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).