* [PATCH 5/8] refs: use is_pseudoref_syntax() in refname_is_safe()
@ 2024-04-29 8:23 Jeff King
0 siblings, 0 replies; only message in thread
From: Jeff King @ 2024-04-29 8:23 UTC (permalink / raw
To: git; +Cc: Patrick Steinhardt
The open-coded logic in refname_is_safe() predates the addition of
is_pseudoref_syntax(). But now that we have it, we can make use of it.
This shortens the code, but also makes sure we use a consistent
definition of a pseudoref.
Note that refname_is_safe() allows HEAD, which of course is not itself a
pseudoref by the strict definition (since it can be a symref). But the
syntax for the two is the same, and that is all that we care about here.
Signed-off-by: Jeff King <peff@peff.net>
---
refs.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/refs.c b/refs.c
index b202dca904..8cac7e7e59 100644
--- a/refs.c
+++ b/refs.c
@@ -362,12 +362,7 @@ int refname_is_safe(const char *refname)
return result;
}
- do {
- if (!isupper(*refname) && *refname != '_')
- return 0;
- refname++;
- } while (*refname);
- return 1;
+ return is_pseudoref_syntax(refname);
}
/*
--
2.45.0.rc1.416.gbe2a76c799
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-29 8:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 8:23 [PATCH 5/8] refs: use is_pseudoref_syntax() in refname_is_safe() Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).