From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Han Young <hanyang.tony@bytedance.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 0/1] quote: quote space
Date: Thu, 28 Mar 2024 12:30:28 -0400 [thread overview]
Message-ID: <20240328163028.GB1403492@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq34sawcqr.fsf@gitster.g>
On Thu, Mar 28, 2024 at 09:19:08AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> >> With the following band-aid, we can skip the test and the output
> >> from "sh t4126-*.sh -i -v -x" might give us a clue that explains how
> >> such a failure happens. Unfortunately GitHub CI's win test does not
> >> give us insight into a test that did not fail, so I did not get
> >> anything useful from the "ls -l" down there (I already knew that
> >> sample patches are empty files).
> >
> > We package up the failed test output and trash directories for each run.
> > You can find the one for this case here:
> >
> > https://github.com/git/git/actions/runs/8458842054/artifacts/1364695605
>
> What I meant was that with the band-aid that (1) sets prerequisite
> so that Windows would not fail and (2) has some diagnostic in the
> code that sets prerequisite, because the overall test does not fail,
> we do not package up that diagnostic output.
Right, I meant that we could look at the run without the band-aid (which
is what the link points to). But I guess maybe you realized already that
it would not be helpful because of the "reset --hard" that the test
does.
-Peff
next prev parent reply other threads:[~2024-03-28 16:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 9:52 [PATCH 0/1] quote: quote space Han Young
2024-03-19 9:52 ` [PATCH 1/1] " Han Young
2024-03-19 9:59 ` Kristoffer Haugsbakk
2024-03-19 15:15 ` [PATCH 0/1] " Junio C Hamano
2024-03-19 22:56 ` Junio C Hamano
2024-03-26 21:41 ` Junio C Hamano
2024-03-27 9:17 ` Jeff King
2024-03-27 14:59 ` Junio C Hamano
2024-03-27 22:11 ` Junio C Hamano
2024-03-28 10:32 ` Jeff King
2024-03-28 11:40 ` Jeff King
2024-03-28 17:05 ` Eric Sunshine
2024-03-28 17:31 ` Junio C Hamano
2024-03-28 21:08 ` [PATCH v2] t4126: make sure a directory with SP at the end is usable Junio C Hamano
2024-03-29 2:18 ` Junio C Hamano
2024-03-29 5:37 ` [PATCH] t4126: fix "funny directory name" test on Windows (again) Junio C Hamano
2024-03-29 12:00 ` Jeff King
2024-03-29 17:21 ` [PATCH v2] " Junio C Hamano
2024-03-29 18:34 ` Jeff King
2024-03-29 11:27 ` [PATCH v2] t4126: make sure a directory with SP at the end is usable Jeff King
2024-03-29 17:01 ` Junio C Hamano
2024-04-27 14:47 ` Johannes Schindelin
2024-04-27 17:20 ` Junio C Hamano
2024-03-28 16:19 ` [PATCH 0/1] quote: quote space Junio C Hamano
2024-03-28 16:30 ` Jeff King [this message]
2024-03-28 16:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328163028.GB1403492@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanyang.tony@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).