Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Jeff King <>
To: Junio C Hamano <>
Cc:, Han Young <>,
	Johannes Schindelin <>
Subject: Re: [PATCH 0/1] quote: quote space
Date: Thu, 28 Mar 2024 06:32:54 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <xmqqsf0bz5oj.fsf@gitster.g>

On Wed, Mar 27, 2024 at 03:11:08PM -0700, Junio C Hamano wrote:

> This seems to fail only on Windows, and I have run out of my today's
> allotment of time for this topic.
> The earlier part that creates the directory with a trailing SP,
> redirects to a file in such a directory to create an empty file, and
> adds that path to the index, all succeed and follow the &&-chain,
> but the step that runs "git diff" with "funny /" (i.e. the name of
> the directory a trailing slash) as the pathspec produces an empty
> patch, and "git apply" would of course choke on an empty file as an
> input.
> With the following band-aid, we can skip the test and the output
> from "sh t4126-*.sh -i -v -x" might give us a clue that explains how
> such a failure happens.  Unfortunately GitHub CI's win test does not
> give us insight into a test that did not fail, so I did not get
> anything useful from the "ls -l" down there (I already knew that
> sample patches are empty files).

We package up the failed test output and trash directories for each run.
You can find the one for this case here:

It is sometimes misleading because we don't run with "-i", so subsequent
tests may stomp on things. But in this case the failing test is the last
one. Unfortunately, I don't think it shows us much, because the state we
tried to diff is removed by the test itself (both the funny dir and the
index after we tried to add it).

So I don't know if we failed to even create "funny /" in the first
place, if adding it to the index failed, or if the diff somehow failed.

On the plus side, while trying to find the failing CI job, I ran across
and diagnosed two other unrelated failures in "seen". ;)


  reply	other threads:[~2024-03-28 10:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19  9:52 [PATCH 0/1] quote: quote space Han Young
2024-03-19  9:52 ` [PATCH 1/1] " Han Young
2024-03-19  9:59   ` Kristoffer Haugsbakk
2024-03-19 15:15 ` [PATCH 0/1] " Junio C Hamano
2024-03-19 22:56   ` Junio C Hamano
2024-03-26 21:41     ` Junio C Hamano
2024-03-27  9:17     ` Jeff King
2024-03-27 14:59       ` Junio C Hamano
2024-03-27 22:11     ` Junio C Hamano
2024-03-28 10:32       ` Jeff King [this message]
2024-03-28 11:40         ` Jeff King
2024-03-28 17:05           ` Eric Sunshine
2024-03-28 17:31             ` Junio C Hamano
2024-03-28 21:08               ` [PATCH v2] t4126: make sure a directory with SP at the end is usable Junio C Hamano
2024-03-29  2:18                 ` Junio C Hamano
2024-03-29  5:37                   ` [PATCH] t4126: fix "funny directory name" test on Windows (again) Junio C Hamano
2024-03-29 12:00                     ` Jeff King
2024-03-29 17:21                     ` [PATCH v2] " Junio C Hamano
2024-03-29 18:34                       ` Jeff King
2024-03-29 11:27                   ` [PATCH v2] t4126: make sure a directory with SP at the end is usable Jeff King
2024-03-29 17:01                     ` Junio C Hamano
2024-04-27 14:47                       ` Johannes Schindelin
2024-04-27 17:20                         ` Junio C Hamano
2024-03-28 16:19         ` [PATCH 0/1] quote: quote space Junio C Hamano
2024-03-28 16:30           ` Jeff King
2024-03-28 16:53             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).