From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/14] more -Wunused-parameter annotations
Date: Mon, 3 Jul 2023 02:43:47 -0400 [thread overview]
Message-ID: <20230703064347.GA3524892@coredump.intra.peff.net> (raw)
Here's another set of patches to silence -Wunused-parameter warnings.
With the exception of the first patch, these are all just adding
annotations (though I tried to document in each one any digging I did on
"this isn't a bug that we're not using it, right?").
So I don't think these should be controversial. But I wanted to mention
that I'll be offline for a month starting July 5th. So if there is any
substantive review after that, I'll be rather slow to respond. :)
[01/14]: test-ref-store: drop unimplemented reflog-expire command
[02/14]: do_for_each_ref_helper(): mark unused repository parameter
[03/14]: http: mark unused parameters in curl callbacks
[04/14]: http-push: mark unused parameter in xml callback
[05/14]: am: mark unused keep_cr parameters
[06/14]: count-objects: mark unused parameter in alternates callback
[07/14]: revisions: drop unused "opt" parameter in "tweak" callbacks
[08/14]: fsck: mark unused parameters in various fsck callbacks
[09/14]: merge-tree: mark unused parameter in traverse callback
[10/14]: replace: mark unused parameter in ref callback
[11/14]: replace: mark unused parameter in each_mergetag_fn callback
[12/14]: rev-parse: mark unused parameter in for_each_abbrev callback
[13/14]: tag: mark unused parameters in each_tag_name_fn callbacks
[14/14]: t/helper: mark unused callback void data parameters
builtin/am.c | 4 ++--
builtin/count-objects.c | 2 +-
builtin/diff-tree.c | 2 +-
builtin/fsck.c | 10 +++++-----
builtin/index-pack.c | 3 ++-
builtin/log.c | 6 ++----
builtin/merge-tree.c | 4 +++-
builtin/mktag.c | 8 ++++----
builtin/replace.c | 4 ++--
builtin/rev-parse.c | 2 +-
builtin/tag.c | 4 ++--
builtin/unpack-objects.c | 3 ++-
fsck.c | 4 ++--
http-push.c | 2 +-
http.c | 9 ++++++---
object-file.c | 10 +++++-----
refs.c | 2 +-
revision.c | 2 +-
revision.h | 2 +-
t/helper/test-dump-split-index.c | 2 +-
t/helper/test-oid-array.c | 2 +-
t/helper/test-ref-store.c | 6 ------
22 files changed, 46 insertions(+), 47 deletions(-)
-Peff
next reply other threads:[~2023-07-03 6:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 6:43 Jeff King [this message]
2023-07-03 6:43 ` [PATCH 01/14] test-ref-store: drop unimplemented reflog-expire command Jeff King
2023-07-03 6:44 ` [PATCH 02/14] do_for_each_ref_helper(): mark unused repository parameter Jeff King
2023-07-03 6:44 ` [PATCH 03/14] http: mark unused parameters in curl callbacks Jeff King
2023-07-03 6:44 ` [PATCH 04/14] http-push: mark unused parameter in xml callback Jeff King
2023-07-03 6:44 ` [PATCH 05/14] am: mark unused keep_cr parameters Jeff King
2023-07-03 6:44 ` [PATCH 06/14] count-objects: mark unused parameter in alternates callback Jeff King
2023-07-03 6:44 ` [PATCH 07/14] revisions: drop unused "opt" parameter in "tweak" callbacks Jeff King
2023-07-03 6:44 ` [PATCH 08/14] fsck: mark unused parameters in various fsck callbacks Jeff King
2023-07-03 6:44 ` [PATCH 09/14] merge-tree: mark unused parameter in traverse callback Jeff King
2023-07-03 6:44 ` [PATCH 10/14] replace: mark unused parameter in ref callback Jeff King
2023-07-03 6:44 ` [PATCH 11/14] replace: mark unused parameter in each_mergetag_fn callback Jeff King
2023-07-03 6:44 ` [PATCH 12/14] rev-parse: mark unused parameter in for_each_abbrev callback Jeff King
2023-07-03 6:44 ` [PATCH 13/14] tag: mark unused parameters in each_tag_name_fn callbacks Jeff King
2023-07-03 6:44 ` [PATCH 14/14] t/helper: mark unused callback void data parameters Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703064347.GA3524892@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).