From: Jeff King <peff@peff.net>
To: Tiago d'Almeida <tjamadeira@gmail.com>
Cc: Derrick Stolee <derrickstolee@github.com>, git@vger.kernel.org
Subject: index.skipHash doesn't work with split index, was Re: Bug Report
Date: Thu, 29 Jun 2023 04:38:59 -0400 [thread overview]
Message-ID: <20230629083859.GA585934@coredump.intra.peff.net> (raw)
In-Reply-To: <CAO=RawtAvOna1xrBNY+T-fo4UQe-ipC6OvFODvOSdu4wUML3Ng@mail.gmail.com>
On Tue, Jun 27, 2023 at 05:02:30PM +0100, Tiago d'Almeida wrote:
> Attached to this email follow the `git bugreport` and global `config`
> files, and the git_bug repo.
Thanks for providing your config; it was very important to reproducing.
The bug comes from the combination of "core.splitIndex" and
"index.skipHash" (the latter is triggered in your config by
"feature.manyFiles").
Here's a quick reproduction:
git init repo
cd repo
touch file
git -c core.splitIndex=true -c index.skipHash=true add file
That should add "file" to the index but doesn't. Removing either the
splitIndex option or the skipHash option makes it work. I didn't dig
further than that.
Adding the author of skipHash to the cc.
-Peff
next prev parent reply other threads:[~2023-06-29 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 16:02 Bug Report Tiago d'Almeida
2023-06-29 8:38 ` Jeff King [this message]
[not found] ` <2FG8XR.63MILGOHGRJ91@gmail.com>
[not found] ` <UCH8XR.AR4M4C9D538Q1@gmail.com>
2023-07-03 19:16 ` index.skipHash doesn't work with split index, was " Jeff King
2023-07-05 14:27 ` Johannes Schindelin
2023-07-05 17:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629083859.GA585934@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=tjamadeira@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).