From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Teng Long <dyroneteng@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 3/3] ci: drop linux-clang job
Date: Thu, 1 Jun 2023 14:10:40 -0400 [thread overview]
Message-ID: <20230601181040.GC4167886@coredump.intra.peff.net> (raw)
In-Reply-To: <20230601180220.GA4167745@coredump.intra.peff.net>
Since the linux-asan-ubsan job runs using clang under Linux, there is
not much point in running a separate clang job. Any errors that a normal
clang compile-and-test cycle would find are likely to be a subset of
what the sanitizer job will find. Since this job takes ~14 minutes to
run in CI, this shaves off some of our CPU load (though it does not
affect end-to-end runtime, since it's typically run in parallel and is
not the longest job).
Technically this provides us with slightly less signal for a given run,
since you won't immediately know if a failure in the sanitizer job is
from using clang or from the sanitizers themselves. But it's generally
obvious from the logs, and anyway your next step would be to fix the
probvlem and re-run CI, since we expect all of these jobs to pass
normally.
Signed-off-by: Jeff King <peff@peff.net>
---
Obviously not necessary, but just seemed like another easy way to trim
our resource usage. Really, the same logic could apply before my series
to the linux-gcc job, which is similarly redundant.
.github/workflows/main.yml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 2114303b7d..079645b776 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -246,9 +246,6 @@ jobs:
fail-fast: false
matrix:
vector:
- - jobname: linux-clang
- cc: clang
- pool: ubuntu-latest
- jobname: linux-sha256
cc: clang
pool: ubuntu-latest
--
2.41.0.346.g8d12207a4f
next prev parent reply other threads:[~2023-06-01 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 18:02 [PATCH 0/3] ci sanitizer cleanups and performance improvements Jeff King
2023-06-01 18:03 ` [PATCH 1/3] ci: use clang for ASan/UBSan checks Jeff King
2023-06-01 18:09 ` [PATCH 2/3] ci: run ASan/UBSan in a single job Jeff King
2023-06-01 18:10 ` Jeff King [this message]
2023-06-03 1:35 ` [PATCH 0/3] ci sanitizer cleanups and performance improvements Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601181040.GC4167886@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).