Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/2] a few format-patch leak fixes
Date: Thu, 18 May 2023 20:02:39 -0400	[thread overview]
Message-ID: <20230519000239.GA1975039@coredump.intra.peff.net> (raw)

I got bit earlier by the leak-checker complaining about an old leak on
jc/send-email-pre-process-fix, so I started to poke at the code.  I see
that you since silenced it via 20bd08aefb (t9001: mark the script as no
longer leak checker clean, 2023-05-17).

I think that's an OK solution for the release period. But since I dug
into the actual leak, I didn't want those fixes to go to waste. :)

So these can be applied at our leisure post-release, though I think the
first one could also be taken independently, and is enough to fix t9001
(obviously we could also take them both, but the first one is the less
risky of the two, since we're in an -rc period).

  [1/2]: format-patch: free rev.message_id when exiting
  [2/2]: format-patch: free elements of rev.ref_message_ids list

 builtin/log.c         | 15 ++++++++-------
 t/t9001-send-email.sh |  2 +-
 2 files changed, 9 insertions(+), 8 deletions(-)

-Peff

             reply	other threads:[~2023-05-19  0:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19  0:02 Jeff King [this message]
2023-05-19  0:03 ` [PATCH 1/2] format-patch: free rev.message_id when exiting Jeff King
2023-05-19  0:05 ` [PATCH 2/2] format-patch: free elements of rev.ref_message_ids list Jeff King
2023-05-19  1:32   ` Junio C Hamano
2023-05-19 14:54   ` Konstantin Khomoutov
2023-05-19 16:56     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230519000239.GA1975039@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).