From: Jeff King <peff@peff.net>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org, Matthew John Cheetham <mjcheetham@outlook.com>
Subject: Re: [BUG 2.41.0] t/lib-httpd/apache.conf incompatible with RHEL/CentOS 7
Date: Thu, 18 May 2023 15:22:48 -0400 [thread overview]
Message-ID: <20230518192248.GB1514485@coredump.intra.peff.net> (raw)
In-Reply-To: <ZGZ5KsbkwoT68J1S@pobox.com>
On Thu, May 18, 2023 at 03:14:50PM -0400, Todd Zullinger wrote:
> > 1. You use the looser value of GIT_TEST_HTTPD for CentOS tests, which
> > would do the right thing. The downside is that if server setup
> > failed for other reasons, we wouldn't notice and would silently
> > skip the HTTP tests.
> >
> > 2. We do some kind of version check in enable_cgipassauth(),
> > and skip tests manually if it doesn't pass.
> >
> > 3. You just skip the test manually on that platform with
> > GIT_SKIP_TESTS=t5563.
> >
> > Obviously (1) and (3) are the least work for us upstream, but I don't
> > think (2) would be too hard to do.
>
> Yeah, the path of least effort seems ideal here. If the
> tests are split I can easily skip them for CentOS 7. For
> something that's going away in little over a year, it's good
> to put at least some of the onus on folks packaging for it.
> And that's less cruft in the test suite after CentOS 7 is
> gone (or any other ancient httpd's git may wish to support).
Too late. :) I just sent a patch with (2), as it was only a few extra
lines.
> Thanks Peff! I'm really glad you know your way around the
> test suite so well. It'd take me far longer to figure out a
> good plan for something like this.
I was able to cheat a little, having had to figure out a similar
solution for HTTP/2 not too long ago. :)
-Peff
next prev parent reply other threads:[~2023-05-18 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 19:06 [BUG 2.41.0] t/lib-httpd/apache.conf incompatible with RHEL/CentOS 7 Todd Zullinger
2023-05-18 18:45 ` Jeff King
2023-05-18 19:14 ` Todd Zullinger
2023-05-18 19:22 ` Jeff King [this message]
2023-05-18 19:21 ` Jeff King
2023-05-18 19:50 ` Todd Zullinger
2023-05-18 20:11 ` Todd Zullinger
2023-05-18 21:31 ` Junio C Hamano
2023-05-18 21:28 ` Junio C Hamano
2023-05-18 23:10 ` Jeff King
2023-05-18 23:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518192248.GB1514485@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=mjcheetham@outlook.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).