From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/3] fix use of "! test_path_is_foo" in tests
Date: Mon, 15 May 2023 19:26:43 -0700 [thread overview]
Message-ID: <20230516022646.648123-1-gitster@pobox.com> (raw)
During recent review of a topic, I noticed that there are a handful
of places where we misuse test_path_is_{file,directory} test helper
functions. They are designed to be silent when the given path is
of the expected type, so
! test_path_is_file foo
when you do not want 'foo' to be a file, while making the test pass,
does not help debugging when things go wrong.
These small patches touch the places where
$ git grep -e '! test_path_' t/
shows hits, except for test_path_is_hidden that shares the same name
pattern but is not designed to help debugging like others.
Junio C Hamano (3):
tests: do not negate test_path_exists
t2021: do not negate test_path_is_dir
test: do not negate test_path_is_* to assert absense
t/lib-submodule-update.sh | 2 +-
t/t2021-checkout-overwrite.sh | 2 +-
t/t4067-diff-partial-clone.sh | 4 ++--
t/t4115-apply-symlink.sh | 2 +-
t/t5572-pull-submodule.sh | 4 ++--
5 files changed, 7 insertions(+), 7 deletions(-)
--
2.41.0-rc0
next reply other threads:[~2023-05-16 2:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 2:26 Junio C Hamano [this message]
2023-05-16 2:26 ` [PATCH 1/3] tests: do not negate test_path_exists Junio C Hamano
2023-05-16 2:53 ` Eric Sunshine
2023-05-16 16:10 ` Junio C Hamano
2023-05-16 2:26 ` [PATCH 2/3] t2021: do not negate test_path_is_dir Junio C Hamano
2023-05-16 2:26 ` [PATCH 3/3] test: do not negate test_path_is_* to assert absense Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516022646.648123-1-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).