From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3FAC6FD18 for ; Sat, 22 Apr 2023 18:55:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbjDVSzJ convert rfc822-to-8bit (ORCPT ); Sat, 22 Apr 2023 14:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjDVSzI (ORCPT ); Sat, 22 Apr 2023 14:55:08 -0400 Received: from secure.elehost.com (secure.elehost.com [185.209.179.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D6021BC2 for ; Sat, 22 Apr 2023 11:55:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at secure.elehost.com Received: from Mazikeen (cpebc4dfb928313-cmbc4dfb928310.cpe.net.cable.rogers.com [99.228.251.108] (may be forged)) (authenticated bits=0) by secure.elehost.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTPSA id 33MIs3Th969146 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 22 Apr 2023 18:54:03 GMT Reply-To: From: To: "'Jeremy Morton'" , References: <8fe188a9-c01f-9fb5-5877-8ff508094b22@game-point.net> In-Reply-To: <8fe188a9-c01f-9fb5-5877-8ff508094b22@game-point.net> Subject: RE: Proposal: tell git a file has been renamed Date: Sat, 22 Apr 2023 14:54:55 -0400 Organization: Nexbridge Inc. Message-ID: <01cd01d9754b$f12326b0$d3697410$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLKSEVgGV7VqNVq5ZPBoEDYjfkU861WBuqQ Content-Language: en-ca Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Saturday, April 22, 2023 2:02 PM, Jeremy Morton wrote: >Yes, I know Linus specifically doesn't store file rename info in Git. >The trouble is, every now and then, I'll come across a situation where Git doesn't >successfully detect that I've renamed a file because I'm doing something like >renaming a class at the same time. So I'll have a file OldClassNameTests.cs and a >NewClassNameTests.cs but a bunch of lines in that file have also changed from >OldClassName.DoThing() to NewClassName.DoThing(). I can clearly see that this is a >rename, but Git sees enough changed content that it doesn't realize it, and puts it in >as a delete/add, losing the content history. > >The standard answer for this is to rename the file in one commit, then make the >changes. That's fine if you know ahead of time you'll want to do this. However it's a >total PITA if you have a bunch of changes and you realize that a rename has caused >this problem. You now have to back out your changes to the renamed file, add the >rename, commit it, then re-apply the changes. > >Could a command be added to git that means you tell Git that counts as a file >rename? Git would add a marker to the staging area that the file has been renamed, >and upon commit, would first generate an additional commit for each rename before >generating the main commit, ensuring the rename operation counts as an actual >rename, and the content's history is maintained. Would git mv work in your situation? You can stage changes to the original file, then use git mv. Or use git mv first. The rename shows as staged in any event. --Randall