From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from secure.elehost.com (secure.elehost.com [185.209.179.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7921D57868 for ; Tue, 13 Feb 2024 14:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.209.179.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707835045; cv=none; b=pdAs5acJ5G+pjkAaihP5o0dng+LGInU2Zb4ADM1CouYMn575L9J4ysbvgpyz1D7AStJI8L6N1HAwsqT+HTQ0KzhVtfBVF0kq4xypTpaqCfJHo7KOCQ9jGQQP19R37BMMspl862Og7fKmN+ut/Efo3N3YKYUvfKnpte1f1iSAM2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707835045; c=relaxed/simple; bh=WoWRc2CbsX5o8Yr6LXB1JqtlwtXrm3L6GqpZdcCz3dE=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=dDF8a4/7ACLH1pUEPXlrhlwv13l7n/mWUZSi8c/6G8BlZWOl1H4kwYwHCfF3rV1NbVSc/AsqKoEPTjMwzLgZ5kj919jgw4+gGJKIlhNVBputyQ8VfjzooH8IxTWACLt6YZbk8GqQZWmYfR5yCraPyXRyE8z0pCwX/YjxbGjolBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com; spf=pass smtp.mailfrom=nexbridge.com; arc=none smtp.client-ip=185.209.179.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexbridge.com X-Virus-Scanned: Debian amavisd-new at secure.elehost.com Received: from Mazikeen (cpebc4dfb928313-cmbc4dfb928310.cpe.net.cable.rogers.com [99.228.251.108] (may be forged)) (authenticated bits=0) by secure.elehost.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTPSA id 41DEb04E3798095 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 14:37:00 GMT Reply-To: From: To: "'Jeff King'" , "'Junio C Hamano'" Cc: "'Josh Steadmon'" , , , References: <20240207225802.GA538110@coredump.intra.peff.net> <20240213074118.GA2225494@coredump.intra.peff.net> In-Reply-To: <20240213074118.GA2225494@coredump.intra.peff.net> Subject: RE: [RFC PATCH v2 1/6] t0080: turn t-basic unit test into a helper Date: Tue, 13 Feb 2024 09:36:54 -0500 Organization: Nexbridge Inc. Message-ID: <016c01da5e8a$1ada8fc0$508faf40$@nexbridge.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIssOVLS8sqB28S9JSX6UZPm2IKnQIcq8MKAgMoudwB8/Zk4wJvkolkAfmHKQsBAfOFkrAHu1JA Content-Language: en-ca On Tuesday, February 13, 2024 2:41 AM, Peff wrote: >On Mon, Feb 12, 2024 at 01:27:11PM -0800, Junio C Hamano wrote: > >> Josh Steadmon writes: >> >> > I see this line in the docs [1]: "As with wildcard expansion in >> > rules, the results of the wildcard function are sorted". GNU Make >> > has restored the sorted behavior of $(wildcard) since 2018 [2]. = I'll >> > leave the sort off for now, but if folks feel like we need to >> > support older versions of `make`, I'll add it back. >> > >> > [1] >> > = https://www.gnu.org/software/make/manual/html_node/Wildcard-Function >> > .html [2] https://savannah.gnu.org/bugs/index.php?52076 >> >> Thanks for digging. I thought I was certain that woldcard is sorted >> and stable and was quite perplexed when I could not find the mention >> in a version of doc I had handy ("""This is Edition 0.75, last = updated >> 19 January 2020, of 'The GNU Make Manual', for GNU 'make' >> version 4.3."""). > >Likewise (mine is the latest version in Debian unstable). The change to = sort comes >from their[1] eedea52a, which was in GNU make 4.2.90. But the matching >documentation change didn't happen until 5b993ae, which was >4.3.90 in late 2021. So that explains the mystery. > >Those dates imply to me that we should keep the $(sort), though. Six = years is not so >long in distro timescales, especially given that Debian unstable is on = a 4-year-old >version. (And if we did want to get rid of it, certainly we should do = so consistently >across the Makefile in a separate patch). I am stuck on 4.2.1 and cannot get to 4.3.90 any time soon. Can you want = on this? It will take us out unless we can suppress the $(sort) Sincerely, Randall