From: <rsbecker@nexbridge.com>
To: <rsbecker@nexbridge.com>, <git@vger.kernel.org>
Subject: RE: [BUG] Git 2.38.0-rc1 t1800 message text comparison
Date: Wed, 14 Dec 2022 00:53:31 -0500 [thread overview]
Message-ID: <013701d90f80$692ba9c0$3b82fd40$@nexbridge.com> (raw)
In-Reply-To: <003501d8cf8d$21ce5ba0$656b12e0$@nexbridge.com>
On September 23, 2022 4:43 PM, I wrote:
>On September 22, 2022 3:03 PM, I wrote:
>>On September 22, 2022 3:02 PM, I wrote:
>>>Rc1 is looking good except for this test.
>>>
>>>We get a diff as follows:
>>>
>>>-fatal: cannot run bad-hooks/test-hook: ...
>>>+fatal: cannot exec 'bad-hooks/test-hook': Permission denied
>>>
>>>It looks like the pattern
>>>sed -e s/test-hook: .*/test-hook: .../
>>>
>>>needs to be a bit extended. Adding
>>>
>>>sed -e s/exec/run/ | send -e s/["']//g
>>>
>>>might help clear off the other noise.
>
>A patch that might work is as follows:
>
>diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh index 43fcb7c0bf..9a723631a2
>100755
>--- a/t/t1800-hook.sh
>+++ b/t/t1800-hook.sh
>@@ -173,7 +173,10 @@ test_expect_success 'git hook run a hook with a bad
>shebang' '
> -c core.hooksPath=bad-hooks \
> hook run test-hook >out 2>err &&
> test_must_be_empty out &&
>- sed -e "s/test-hook: .*/test-hook: .../" <err >actual &&
>+ quot=`echo "\047"` &&
>+ sed -e "s/exec/run/" <err | \
>+ sed -e "s/$quot//g" | \
>+ sed -e "s/test-hook: .*/test-hook: .../" >actual &&
> test_cmp expect actual
> '
>
>This does not require setting up a prerequisite for NonStop and the
technique
>might make the MING code easier but adding a change from spawn to run.
This is still broken on NonStop. Is there any hope of a resolution?
Thanks,
Randall
next prev parent reply other threads:[~2022-12-14 5:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 19:01 [BUG] Git 2.28.0-rc1 t1800 message text comparison rsbecker
2022-09-22 19:02 ` [BUG] Git 2.38.0-rc1 " rsbecker
2022-09-23 20:43 ` rsbecker
2022-12-14 5:53 ` rsbecker [this message]
2023-05-22 20:39 ` René Scharfe
2023-05-22 20:49 ` rsbecker
2023-05-22 21:13 ` rsbecker
2023-06-04 12:13 ` René Scharfe
2023-06-04 20:55 ` René Scharfe
2023-06-06 0:31 ` Junio C Hamano
2023-06-10 14:51 ` [PATCH 1/2] t1800: loosen matching of error message for bad shebang René Scharfe
2023-06-12 18:01 ` Junio C Hamano
2023-06-10 14:51 ` [PATCH 2/2] run-command: report exec error even on ENOENT René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013701d90f80$692ba9c0$3b82fd40$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).