From: Song Liu <song@kernel.org>
To: KP Singh <kpsingh@kernel.org>
Cc: bpf@vger.kernel.org, fsverity@lists.linux.dev, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org,
kernel-team@meta.com, ebiggers@kernel.org, tytso@mit.edu,
roberto.sassu@huaweicloud.com
Subject: Re: [PATCH v2 bpf-next 4/9] bpf: Add kfunc bpf_get_file_xattr
Date: Wed, 1 Nov 2023 23:43:41 -0700 [thread overview]
Message-ID: <CAPhsuW5_P7R5mcv6hYfC_7JAp8Arrf2UdErgqKy+FLG=57yFMA@mail.gmail.com> (raw)
In-Reply-To: <CACYkzJ7mz91WuvC=9CWA-ewh6ywCHseiH5-dY0jOA0Piw3jQ-g@mail.gmail.com>
On Wed, Nov 1, 2023 at 6:27 PM KP Singh <kpsingh@kernel.org> wrote:
>
> On Mon, Oct 23, 2023 at 8:14 AM Song Liu <song@kernel.org> wrote:
> >
> > This kfunc can be used to read xattr of a file. To avoid recursion, only
> > allow calling this kfunc from LSM hooks.
>
> I think this needs a bit more explanation in the commit message (some
> details on what it could be used for, we can explain the use case
> about persistent LSM policy and LSM signatures with FSVerity). I know
> you add a selftest but some more details in the commit message would
> help.
Sure, I will add a short description here.
> What about adding the KF_TRUSTED_ARGS for the kfunc?
Yeah, I was thinking about this. Adding it to the next version.
Thanks,
Song
[...]
next prev parent reply other threads:[~2023-11-02 6:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 6:13 [PATCH v2 bpf-next 0/9] bpf: File verification with LSM and fsverity Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 1/9] bpf: Expose bpf_dynptr_slice* kfuncs for in kernel use Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 2/9] bpf: Factor out helper check_reg_const_str() Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 3/9] bpf: Introduce KF_ARG_PTR_TO_CONST_STR Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 4/9] bpf: Add kfunc bpf_get_file_xattr Song Liu
2023-11-02 1:27 ` KP Singh
2023-11-02 6:43 ` Song Liu [this message]
2023-10-23 6:13 ` [PATCH v2 bpf-next 5/9] bpf, fsverity: Add kfunc bpf_get_fsverity_digest Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 6/9] Documentation/bpf: Add documentation for filesystem kfuncs Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 7/9] selftests/bpf: Sort config in alphabetic order Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 8/9] selftests/bpf: Add tests for filesystem kfuncs Song Liu
2023-10-23 6:13 ` [PATCH v2 bpf-next 9/9] selftests/bpf: Add test that use fsverity and xattr to sign a file Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW5_P7R5mcv6hYfC_7JAp8Arrf2UdErgqKy+FLG=57yFMA@mail.gmail.com' \
--to=song@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@kernel.org \
--cc=roberto.sassu@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).