From: Alexander Larsson <alexl@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: ebiggers@kernel.org, tytso@mit.edu, miklos@szeredi.hu,
linux-unionfs@vger.kernel.org, fsverity@lists.linux.dev
Subject: Re: [PATCH v3 0/4] ovl: Add support for fs-verity checking of lowerdata
Date: Thu, 6 Jul 2023 09:50:50 +0200 [thread overview]
Message-ID: <CAL7ro1HzspAnCMX-EK3gzaggPqTCEREv1qzeQSTuNhGyM8ESaQ@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxhiU-y=dMocoSGb75Rze_jOLp82MctB26yFYPT3CMOM3g@mail.gmail.com>
On Thu, Jul 6, 2023 at 9:10 AM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Mon, Jul 3, 2023 at 11:11 AM Alexander Larsson <alexl@redhat.com> wrote:
> >
> > Cool, I wanted to look at this, but was on PTO last week.
> > It looks good to me, and I synced this to:
> > https://github.com/alexlarsson/xfstests/commits/verity-tests
> > To avoid drift.
> >
>
> I pushed the overlay-verity series to overlayfs-next, so you may
> expect "finishing touches" bug reports from bots in the near future.
> As long as they are minor fixes, you can fix your branch and let me know
> and I will update overlayfs-next.
>
> Miklos may yet have feedback on the final version, but I think all his
> comments were addressed including the ACK from Eric (thanks!).
Nice!
> Eric,
>
> There was no posting of v5 that addressed your v4 review comments,
> so we do not have your RVB/ACK for patches 2-4.
> Let me know if you want me to add that to the patches.
>
> Alex,
>
> wrt overlay verity-tests, please submit those tests along with the lowerdata
> tests to fstests anytime between now and the 6.6 merge window.
> The tests are properly equipped to check for the feature and testers can
> use them to test linux-next.
I'll have a look at this soon.
> For test overlay/080 you may add:
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> For test overlay/079 you may retain my authorship or assume authorship
> I don't mind as it was co-authored and you took it to the finish line.
>
> Thanks,
> Amir.
>
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl@redhat.com alexander.larsson@gmail.com
next prev parent reply other threads:[~2023-07-06 7:51 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 10:27 [PATCH v3 0/4] ovl: Add support for fs-verity checking of lowerdata Alexander Larsson
2023-06-12 10:27 ` [PATCH v3 1/4] fsverity: Export fsverity_get_digest Alexander Larsson
2023-06-12 10:27 ` [PATCH v3 2/4] ovl: Add framework for verity support Alexander Larsson
2023-06-12 16:32 ` Eric Biggers
2023-06-13 5:18 ` Amir Goldstein
2023-06-13 6:37 ` Eric Biggers
2023-06-13 8:08 ` Alexander Larsson
2023-06-13 9:34 ` Amir Goldstein
2023-06-13 18:22 ` Eric Biggers
2023-06-14 5:24 ` Amir Goldstein
2023-06-14 7:57 ` Alexander Larsson
2023-06-15 23:52 ` Eric Biggers
2023-06-16 8:11 ` Alexander Larsson
2023-06-17 19:47 ` Eric Biggers
2023-06-19 7:58 ` Alexander Larsson
2023-06-12 10:27 ` [PATCH v3 3/4] ovl: Validate verity xattr when resolving lowerdata Alexander Larsson
2023-06-12 10:28 ` Alexander Larsson
2023-06-12 19:09 ` Eric Biggers
2023-06-13 11:41 ` Alexander Larsson
2023-06-13 17:57 ` Eric Biggers
2023-06-14 3:28 ` Eric Biggers
2023-06-14 5:39 ` Amir Goldstein
2023-06-14 7:19 ` Alexander Larsson
2023-06-12 10:28 ` [PATCH v3 4/4] ovl: Handle verity during copy-up Alexander Larsson
2023-06-12 10:52 ` Amir Goldstein
2023-06-12 10:54 ` [PATCH v3 0/4] ovl: Add support for fs-verity checking of lowerdata Amir Goldstein
2023-06-12 11:09 ` Alexander Larsson
2023-06-12 14:53 ` Alexander Larsson
2023-06-12 15:05 ` Amir Goldstein
2023-06-14 6:14 ` Amir Goldstein
2023-06-14 7:07 ` Eric Biggers
2023-06-14 7:16 ` Alexander Larsson
2023-06-22 9:36 ` Amir Goldstein
2023-06-22 9:51 ` Alexander Larsson
2023-06-22 11:45 ` Amir Goldstein
2023-06-26 13:01 ` Amir Goldstein
2023-07-03 8:11 ` Alexander Larsson
2023-07-06 7:10 ` Amir Goldstein
2023-07-06 7:50 ` Alexander Larsson [this message]
2023-06-22 16:12 ` Eric Biggers
2023-06-22 18:07 ` Amir Goldstein
2023-06-13 13:57 ` Alexander Larsson
2023-06-13 17:59 ` Eric Biggers
2023-06-14 7:15 ` Alexander Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL7ro1HzspAnCMX-EK3gzaggPqTCEREv1qzeQSTuNhGyM8ESaQ@mail.gmail.com \
--to=alexl@redhat.com \
--cc=amir73il@gmail.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).