From: Christian Brauner <brauner@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org,
stable@vger.kernel.org,
syzbot+51177e4144d764827c45@syzkaller.appspotmail.com
Subject: Re: [PATCH] fsverity: reject FS_IOC_ENABLE_VERITY on mode 3 fds
Date: Tue, 11 Apr 2023 10:56:16 +0200 [thread overview]
Message-ID: <20230411-abwegen-division-b2370b5667d9@brauner> (raw)
In-Reply-To: <20230406215106.235829-1-ebiggers@kernel.org>
On Thu, Apr 06, 2023 at 02:51:06PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Commit 56124d6c87fd ("fsverity: support enabling with tree block size <
> PAGE_SIZE") changed FS_IOC_ENABLE_VERITY to use __kernel_read() to read
> the file's data, instead of direct pagecache accesses.
>
> An unintended consequence of this is that the
> 'WARN_ON_ONCE(!(file->f_mode & FMODE_READ))' in __kernel_read() became
> reachable by fuzz tests. This happens if FS_IOC_ENABLE_VERITY is called
> on a fd opened with access mode 3, which means "ioctl access only".
>
> Arguably, FS_IOC_ENABLE_VERITY should work on ioctl-only fds. But
> ioctl-only fds are a weird Linux extension that is rarely used and that
> few people even know about. (The documentation for FS_IOC_ENABLE_VERITY
> even specifically says it requires O_RDONLY.) It's probably not
> worthwhile to make the ioctl internally open a new fd just to handle
> this case. Thus, just reject the ioctl on such fds for now.
>
> Fixes: 56124d6c87fd ("fsverity: support enabling with tree block size < PAGE_SIZE")
> Reported-by: syzbot+51177e4144d764827c45@syzkaller.appspotmail.com
> Link: https://syzkaller.appspot.com/bug?id=2281afcbbfa8fdb92f9887479cc0e4180f1c6b28
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
prev parent reply other threads:[~2023-04-11 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 21:51 [PATCH] fsverity: reject FS_IOC_ENABLE_VERITY on mode 3 fds Eric Biggers
2023-04-07 8:09 ` Christoph Hellwig
2023-04-11 8:56 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411-abwegen-division-b2370b5667d9@brauner \
--to=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+51177e4144d764827c45@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).