From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, zlang@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] misc: fix test that fail formatting with 64k blocksize
Date: Wed, 13 Mar 2024 19:58:23 +0100 [thread overview]
Message-ID: <ggfjwyuci4l4dittobyxc4v4a66qupahnrwfsfrdh7xfavtlqf@q3ahgouvzfb7> (raw)
In-Reply-To: <20240313151629.i23ing6hbsghpm4u@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Wed, Mar 13, 2024 at 11:16:29PM +0800, Zorro Lang wrote:
> On Tue, Feb 27, 2024 at 06:39:45PM +0100, Pankaj Raghav (Samsung) wrote:
> > From: "Darrick J. Wong" <djwong@kernel.org>
> >
> > There's a bunch of tests that fail the formatting step when the test run
> > is configured to use XFS with a 64k blocksize. This happens because XFS
> > doesn't really support that combination due to minimum log size
> > constraints. Fix the test to format larger devices in that case.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > Co-developed-by: Pankaj Raghav <p.raghav@samsung.com>
> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> > ---
>
> This change looks good to me, and it really fixes some testing failures.
>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
Thanks.
>
> BTW, I tested 64k blocksize xfs with this patch, there're still some failed
> test cases. If you're still interested in it, I'd like to list some of them
> as below (diff *.out *.out.bad output).
>
I have some more test fixes but it is happening only when we have LBS,
i.e, 64k bs on a 4k system.
But I had a fix for xfs/558 [1]. Can you see if it fixes it?
[1] https://lore.kernel.org/linux-xfs/20240122111751.449762-2-kernel@pankajraghav.com/
>
> *xfs/558 failed as:*
>
> --- /dev/fd/63 2024-03-12 19:13:26.569223817 -0400
> +++ xfs/558.out.bad 2024-03-12 19:13:26.489224254 -0400
> @@ -1,2 +1,3 @@
> QA output created by 558
> +Expected to hear about writeback iomap invalidations?
> Silence is golden
prev parent reply other threads:[~2024-03-13 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 17:39 [PATCH] misc: fix test that fail formatting with 64k blocksize Pankaj Raghav (Samsung)
2024-03-13 15:16 ` Zorro Lang
2024-03-13 15:52 ` Darrick J. Wong
2024-03-13 18:58 ` Pankaj Raghav (Samsung) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ggfjwyuci4l4dittobyxc4v4a66qupahnrwfsfrdh7xfavtlqf@q3ahgouvzfb7 \
--to=kernel@pankajraghav.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).