From: Pankaj Raghav <p.raghav@samsung.com>
To: <fstests@vger.kernel.org>, <djwong@kernel.org>,
<zlang@redhat.com>, "Dave Chinner" <david@fromorbit.com>
Cc: <mcgrof@kernel.org>, <gost.dev@samsung.com>,
<linux-xfs@vger.kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
Subject: fstest failure due to filesystem size for 16k, 32k and 64k FSB
Date: Tue, 30 Jan 2024 14:18:01 +0100 [thread overview]
Message-ID: <fe7fec1c-3b08-430f-9c95-ea76b237acf4@samsung.com> (raw)
In-Reply-To: CGME20240130131803eucas1p280d9355ca3f8dc94073aff54555e3820@eucas1p2.samsung.com
As I pointed out in my previous thread [1], there are some testcases
in fstests that are failing for FSB 16k, 32k and 64k due to the filesystem
**size** under test. These are failures **upstream** and not due to the ongoing
LBS work.
fstests creates a lot of tiny filesystems to perform some tests. Even though
the minimum fs size allowed to create XFS filesystem is 300 MB, we have special
condition in mkfs to allow smaller filesystems for fstest[2] (This took some time
to figure out as I was splitting my hair how fstest is able to create XFS on top of
25MB images).
The problem comes when we have FSB 16k, 32k and 64k. As we will
require more log space when we have this feature enabled, some test cases are failing
with the following error message:
max log size XXX smaller than min log size YYY, filesystem is too small
Most test cases run without this error message with **rmapbt disabled** for 16k and 64k (see
the test matrix below).
What should be the approach to solve this issue? 2 options that I had in my mind:
1. Similar to [2], we could add a small hack in mkfs xfs to ignore the log space
requirement while running fstests for these profiles.
2. Increase the size of filesystem under test to accommodate these profiles. It could
even be a conditional increase in filesystem size if the FSB > 16k to reduce the impact
on existing FS test time for 4k FSB.
Let me know what would be the best way to move forward.
Here are the results:
Test environment:
kernel Release: 6.8.0-rc1
xfsprogs: 6.5.0
Architecture: aarch64
Page size: 64k
Test matrix:
| Test | 32k rmapbt=0 | 32k rmapbt=1 | 64k rmapbt=0 | 64k rmapbt=1 |
| -------- | --------- | --------- | --------- | --------- |
| generic/042 | fail | fail | fail | fail |
| generic/081 | fail | fail | pass | fail |
| generic/108 | fail | fail | pass | fail |
| generic/455 | fail | fail | pass | fail |
| generic/457 | fail | fail | pass | fail |
| generic/482 | fail | fail | pass | fail |
| generic/704 | fail | fail | pass | fail |
| generic/730 | fail | fail | pass | fail |
| generic/731 | fail | fail | pass | fail |
| shared/298 | pass | pass | pass | fail |
16k fails only on generic/042 for both rmapbt=0 and rmapbt=1
[1] https://lore.kernel.org/all/7964c404-bc9d-47ef-97f1-aaaba7d7aee9@samsung.com/
[2] xfsprogs commit: 6e0ed3d19c54603f0f7d628ea04b550151d8a262
--
Regards,
Pankaj
next parent reply other threads:[~2024-01-30 13:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240130131803eucas1p280d9355ca3f8dc94073aff54555e3820@eucas1p2.samsung.com>
2024-01-30 13:18 ` Pankaj Raghav [this message]
2024-01-30 19:56 ` fstest failure due to filesystem size for 16k, 32k and 64k FSB Darrick J. Wong
2024-01-30 20:34 ` Pankaj Raghav
2024-01-31 3:48 ` Darrick J. Wong
2024-01-31 14:05 ` Pankaj Raghav (Samsung)
2024-01-31 18:28 ` Darrick J. Wong
2024-02-01 15:44 ` Pankaj Raghav (Samsung)
2024-02-02 16:46 ` Darrick J. Wong
2024-02-02 17:18 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7fec1c-3b08-430f-9c95-ea76b237acf4@samsung.com \
--to=p.raghav@samsung.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).