From: Filipe Manana <fdmanana@kernel.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Anand Jain <anand.jain@oracle.com>, Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs/zoned: test premature ENOSPC because of reclaim being too slow
Date: Mon, 22 Jan 2024 12:46:00 +0000 [thread overview]
Message-ID: <CAL3q7H44FfKYCmg3_PQK=swEwr+VrR2mJu2X8kDXFXBNMqgNFA@mail.gmail.com> (raw)
In-Reply-To: <20240122105554.1077035-1-johannes.thumshirn@wdc.com>
On Mon, Jan 22, 2024 at 10:56 AM Johannes Thumshirn
<johannes.thumshirn@wdc.com> wrote:
>
> Add a test writing a file of 60% the drive size on a zoned btrfs and then
> overwriting the file again.
>
> On fast drives this will cause premature ENOSPC because the reclaim
> process isn't triggered fast enough.
>
> The kernel patch for this issue is:
> btrfs: zoned: wake up cleaner sooner if needed
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
> tests/btrfs/310 | 54 +++++++++++++++++++++++++++++++++++++++++++++
> tests/btrfs/310.out | 2 ++
> 2 files changed, 56 insertions(+)
> create mode 100755 tests/btrfs/310
> create mode 100644 tests/btrfs/310.out
>
> diff --git a/tests/btrfs/310 b/tests/btrfs/310
> new file mode 100755
> index 000000000000..6f6f5542f73f
> --- /dev/null
> +++ b/tests/btrfs/310
> @@ -0,0 +1,54 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2024 Western Digital Corporation. All Rights Reserved.
> +#
> +# FS QA Test 310
> +#
> +# Write a single file with 60% disk size to a zoned btrfs and then overwrite
> +# it again. On kernels without the fix this results in ENOSPC.
> +#
> +# This issue is fixed by the following kernel patch:
> +# btrfs: zoned: wake up cleaner sooner if needed
> +
> +. ./common/preamble
> +_begin_fstest auto enospc rw zone
Why the rw group?
The test only exercises writes.
Also the enospc group, I think it's meant to exercise cases that are
expected to hit ENOSPC.
Here we want to verify that we don't hit ENOSPC (or any other error).
Thanks.
> +
> +# real QA test starts here
> +
> +_supported_fs btrfs
> +_require_scratch
> +_require_zoned_device "$SCRATCH_DEV"
> +
> +devsize=$(cat /sys/block/$(_short_dev $SCRATCH_DEV)/size)
> +devsize=$(expr $devsize \* 512)
> +filesize=$(expr $devsize \* 60 / 100)
> +
> +fio_config=$tmp.fio
> +
> +# Override the default cleanup function.
> +_cleanup()
> +{
> + rm -f $tmp.*
> +}
> +
> +cat >$fio_config <<EOF
> +[test]
> +filename=$SCRATCH_MNT/test
> +readwrite=write
> +loops=2
> +filesize=$filesize
> +EOF
> +
> +_require_fio $fio_config
> +
> +_scratch_mkfs >/dev/null 2>&1
> +_scratch_mount
> +
> +$FIO_PROG $fio_config >> $seqres.full
> +
> +_scratch_unmount
> +
> +echo "Silence is golden"
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/btrfs/310.out b/tests/btrfs/310.out
> new file mode 100644
> index 000000000000..7b9eaf78a07a
> --- /dev/null
> +++ b/tests/btrfs/310.out
> @@ -0,0 +1,2 @@
> +QA output created by 310
> +Silence is golden
> --
> 2.43.0
>
>
prev parent reply other threads:[~2024-01-22 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 10:55 [PATCH] btrfs/zoned: test premature ENOSPC because of reclaim being too slow Johannes Thumshirn
2024-01-22 12:25 ` David Disseldorp
2024-01-22 12:34 ` Johannes Thumshirn
2024-01-22 12:46 ` Filipe Manana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL3q7H44FfKYCmg3_PQK=swEwr+VrR2mJu2X8kDXFXBNMqgNFA@mail.gmail.com' \
--to=fdmanana@kernel.org \
--cc=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).