From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>,
fstests@vger.kernel.org
Cc: djwong@kernel.org, gost.dev@samsung.com, mcgrof@kernel.org,
kernel@pankajraghav.com, zlang@redhat.com,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
Date: Tue, 07 May 2024 09:30:24 +0530 [thread overview]
Message-ID: <87jzk6nuef.fsf@gmail.com> (raw)
"Pankaj Raghav (Samsung)" <kernel@pankajraghav.com> writes:
> From: Pankaj Raghav <p.raghav@samsung.com>
>
> This test fails when xfs is formatted with 64k filesystem block size*.
> It fails because the soft quota is not exceeded with the hardcoded 64k
> pwrite, thereby, the grace time is not set. Even though soft quota is
> set to 12k for uid1, it is rounded up to the nearest blocksize.
>
> *** Report for user quotas on device /dev/sdb3
> Block grace time: 7days; Inode grace time: 7days
> Block limits File limits
> User used soft hard grace used soft hard grace
> ----------------------------------------------------------------------
> 0 -- 0 0 0 0 3 0 0 0
> 1 -- 64 64 1024 0 1 0 0 0
> 2 -- 64 0 0 0 1 0 0 0
>
> Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
>
> Cap the blksz to be at least 64k to retain the same behaviour as before
> for smaller filesystem blocksizes.
>
> * This happens even on a 64k pagesize system and it is not related to
> LBS effort.
Indeed! Thanks for fixing this for 64k bs. Please feel free to add -
Reviewed-and-tested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
next reply other threads:[~2024-05-07 4:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 4:00 Ritesh Harjani [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-06 15:01 [PATCH 0/3] more lbs test fixes Pankaj Raghav (Samsung)
2024-05-06 15:01 ` [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize Pankaj Raghav (Samsung)
2024-05-07 22:23 ` Darrick J. Wong
2024-05-08 2:50 ` Ritesh Harjani
2024-05-08 16:06 ` Darrick J. Wong
2024-05-09 13:01 ` Pankaj Raghav (Samsung)
2024-05-08 10:58 ` Pankaj Raghav (Samsung)
2024-05-08 14:49 ` Pankaj Raghav (Samsung)
2024-05-09 17:33 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzk6nuef.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).