FSTests Archive mirror
 help / color / mirror / Atom feed
From: 蔡晓斌 <caixiaobin0807@163.com>
To: fstests@vger.kernel.org
Subject: about the format problem at generic/556, and supply a fix patch
Date: Tue, 2 Apr 2024 09:41:49 +0800 (CST)	[thread overview]
Message-ID: <5c043f11.244a.18e9c783e59.Coremail.caixiaobin0807@163.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]


Hi, when I test my project with xfstests, I found that format problem at generic/556, it looks no like a script, so I adjust format and look so well.


Below is the concent of the patch, and patch file at attachments:



From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file
 look more like a script file


---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/tests/generic/556 b/tests/generic/556
index 404a3243..ccefbcc4 100755
--- a/tests/generic/556
+++ b/tests/generic/556
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
-- 
2.25.1


Thank you and looking forward to your reply.

[-- Attachment #2: 0001-generic-556-reverse-the-order-of-comments-to-make-th.patch --]
[-- Type: application/octet-stream, Size: 682 bytes --]

From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001
From: "cai.xiaobin" <cai.xiaobin@gd-linux.com>
Date: Wed, 20 Mar 2024 11:13:29 +0800
Subject: [PATCH] generic/556: reverse the order of comments to make the file
 look more like a script file

---
 tests/generic/556 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/556 b/tests/generic/556
index 404a3243..ccefbcc4 100755
--- a/tests/generic/556
+++ b/tests/generic/556
@@ -1,5 +1,5 @@
-# SPDX-License-Identifier: GPL-2.0+
 #!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
 # FS QA Test No. 556
 #
 # Test the basic functionality of filesystems with case-insensitive
-- 
2.25.1


             reply	other threads:[~2024-04-02  1:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02  1:41 蔡晓斌 [this message]
2024-04-02  4:51 ` about the format problem at generic/556, and supply a fix patch David Disseldorp
2024-04-02  6:22   ` 蔡晓斌
2024-04-03 10:54     ` Zorro Lang
2024-04-07  2:10       ` 蔡晓斌
2024-04-13 19:49         ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c043f11.244a.18e9c783e59.Coremail.caixiaobin0807@163.com \
    --to=caixiaobin0807@163.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).