From: Anand Jain <anand.jain@oracle.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs: test mount fails on physical device with configured dm volume
Date: Fri, 8 Mar 2024 19:08:33 +0530 [thread overview]
Message-ID: <4df941f0-4044-4d4c-9024-3fcbf0690819@oracle.com> (raw)
In-Reply-To: <20240307192017.4lxymyxhplysad4i@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On 3/8/24 00:50, Zorro Lang wrote:
> On Thu, Mar 07, 2024 at 06:20:24PM +0530, Anand Jain wrote:
>> When a flakey device is configured, we have access to both the physical
>> device and the DM flaky device. Ensure that when the flakey device is
>> configured, the physical device mount fails.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> tests/btrfs/318 | 45 +++++++++++++++++++++++++++++++++++++++++++++
>> tests/btrfs/318.out | 3 +++
>> 2 files changed, 48 insertions(+)
>> create mode 100755 tests/btrfs/318
>> create mode 100644 tests/btrfs/318.out
>>
>> diff --git a/tests/btrfs/318 b/tests/btrfs/318
>> new file mode 100755
>> index 000000000000..015950fbd93c
>> --- /dev/null
>> +++ b/tests/btrfs/318
>> @@ -0,0 +1,45 @@
>> +#! /bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +# Copyright (c) 2024 Oracle. All Rights Reserved.
>> +#
>> +# FS QA Test 318
>> +#
>> +# Create multiple device nodes with the same device try mount
>> +#
>> +. ./common/preamble
>> +_begin_fstest auto volume tempfsid
>> +
>> +# Override the default cleanup function.
>> +_cleanup()
>> +{
>> + umount $extra_mnt &> /dev/null
>> + rm -rf $extra_mnt &> /dev/null
>> + _unmount_flakey
>> + _cleanup_flakey
>> + cd /
>> + rm -r -f $tmp.*
>> +}
>> +
>> +# Import common functions.
>> +. ./common/filter
>> +. ./common/dmflakey
>> +
>> +# real QA test starts here
>> +_supported_fs btrfs
>
> BTW, what cause it have to be a btrfs specific test case? I didn't any
> btrfs specific operations below, can you explain the reason?
>
Right. Now I notice it can be made generic. I have converted this
into a generic test case. I'll send it when the kernel patch is
ready. For now, I have to withdraw this patch.
Thanks for the suggestion.
Anand
prev parent reply other threads:[~2024-03-08 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1709806478.git.anand.jain@oracle.com>
2024-03-07 12:50 ` [PATCH 1/3] .gitignore: add src/fcntl_lock_corner_tests Anand Jain
2024-03-07 15:26 ` Zorro Lang
2024-03-07 15:55 ` Anand Jain
2024-03-07 12:50 ` [PATCH 2/3] common/rc: specify required device size Anand Jain
2024-03-07 15:16 ` Zorro Lang
2024-03-07 16:08 ` Anand Jain
2024-03-07 12:50 ` [PATCH 3/3] btrfs: test mount fails on physical device with configured dm volume Anand Jain
2024-03-07 14:59 ` Zorro Lang
2024-03-07 16:15 ` Filipe Manana
2024-03-07 16:46 ` Anand Jain
2024-03-08 12:30 ` Filipe Manana
2024-03-08 13:35 ` Anand Jain
2024-03-07 19:20 ` Zorro Lang
2024-03-08 13:38 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4df941f0-4044-4d4c-9024-3fcbf0690819@oracle.com \
--to=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).