From: Pankaj Raghav <kernel@pankajraghav.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, djwong@kernel.org, gost.dev@samsung.com,
mcgrof@kernel.org
Subject: Re: [PATCH] xfs/558: scale blk IO size based on the filesystem blksz
Date: Wed, 27 Mar 2024 19:06:23 +0100 [thread overview]
Message-ID: <4c020072-b7b2-4519-b9ff-b80ba50a6419@pankajraghav.com> (raw)
In-Reply-To: <20240327133731.f36a5wtz7hoe7r5b@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
>>> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
>>> Tested-by: Darrick J. Wong <djwong@kernel.org>
>>> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>>> ---
>>
>> Hi Zorro,
>> I checked xfstests/for-next and didn't see this patch queued up. Do I need
>> to do something or will it get queued up for the next release?
>
> Oh sorry, due to this patch was in a patchset with:
>
> [PATCH 2/2] xfs/161: adapt the test case for LBS filesystem
>
> So I don't know if you'd like to have them both together, or merge
> this one (with RVB) at first:)
>
The other patch needs some more discussion I think. Please feel
free to merge this one in as it already has RVB :)
> If you hope to have this one at first, I'll merge it in patches-in-queue branch,
> then have it in next branch.
>
> Thanks,
> Zorro
>
>>
>>> tests/xfs/558 | 7 ++++++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tests/xfs/558 b/tests/xfs/558
>>> index 9e9b3be8..270f458c 100755
>>> --- a/tests/xfs/558
>>> +++ b/tests/xfs/558
>>> @@ -127,7 +127,12 @@ _scratch_mount >> $seqres.full
>>> $XFS_IO_PROG -c 'chattr -x' $SCRATCH_MNT &> $seqres.full
>>> _require_pagecache_access $SCRATCH_MNT
>>>
>>> -blksz=65536
>>> +min_blksz=65536
>>> +file_blksz=$(_get_file_block_size "$SCRATCH_MNT")
>>> +blksz=$(( 8 * $file_blksz ))
>>> +
>>> +blksz=$(( blksz > min_blksz ? blksz : min_blksz ))
>>> +
>>> _require_congruent_file_oplen $SCRATCH_MNT $blksz
>>>
>>> # Make sure we have sufficient extent size to create speculative CoW
>>
>
prev parent reply other threads:[~2024-03-27 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240313203828eucas1p22e2b127e8597e2e72397f26370c54b42@eucas1p2.samsung.com>
2024-03-13 20:38 ` [PATCH] xfs/558: scale blk IO size based on the filesystem blksz Pankaj Raghav (Samsung)
2024-03-26 17:20 ` Pankaj Raghav
2024-03-27 13:37 ` Zorro Lang
2024-03-27 18:06 ` Pankaj Raghav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c020072-b7b2-4519-b9ff-b80ba50a6419@pankajraghav.com \
--to=kernel@pankajraghav.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=mcgrof@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).