From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz
Cc: Zorro Lang <zlang@redhat.com>, David Sterba <dsterba@suse.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH] generic/733: disable for btrfs
Date: Tue, 9 Apr 2024 23:01:03 +0800 [thread overview]
Message-ID: <3b67bdd5-8579-47fa-aec0-898d4750b064@oracle.com> (raw)
In-Reply-To: <20240409144600.GF3492@twin.jikos.cz>
>>>>>> This tests if a clone source can be read but in btrfs there's an
>>>>>> exclusive lock and the test always fails. The functionality might be
>>>>>> implemented in btrfs in the future but for now disable the test.
>>>>>>
>>>>>> CC: Josef Bacik <josef@toxicpanda.com>
>>>>>> Signed-off-by: David Sterba <dsterba@suse.com>
>>>>>> ---
>>>>>> tests/generic/733 | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/tests/generic/733 b/tests/generic/733
>>>>>> index d88d92a4705add..b26fa47dad776f 100755
>>>>>> --- a/tests/generic/733
>>>>>> +++ b/tests/generic/733
>>>>>> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
>>>>>> . ./common/reflink
>>>>>>
>>>>>> # real QA test starts here
>>>>>> -_supported_fs generic
>>>>>> +_supported_fs generic ^btrfs
>>>>>
>>>>> If only need a blacklist, you can write "^btrfs" directly, e.g.
>>>>>
>>>>> _supported_fs ^btrfs
>>>>>
>>>>> then others (except btrfs) are in whitelist, don't need the "generic".
>>>>
>>>> Ok thanks, do I need to resend or would you update the commit?
>>>
>>> I can help to change that, it's simple enough.
>>>
>>
>> Applied for the PR with this changed.
>
> The test generic/733 works after patch
>
> https://lore.kernel.org/linux-btrfs/5fe82cceb3b6f3434172a7fb0e85a21a2f07e99c.1711199153.git.fdmanana@suse.com/
>
> so please keep it.
Ah, appreciate the heads-up!
Thanks, Anand
prev parent reply other threads:[~2024-04-09 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 9:50 [PATCH] generic/733: disable for btrfs David Sterba
2024-02-22 11:34 ` Filipe Manana
2024-02-24 13:42 ` Wang Yugui
2024-02-26 10:14 ` David Sterba
2024-02-25 15:41 ` Zorro Lang
2024-02-26 11:33 ` David Sterba
2024-02-26 18:07 ` Zorro Lang
2024-04-09 14:49 ` Anand Jain
2024-04-09 14:46 ` David Sterba
2024-04-09 15:01 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b67bdd5-8579-47fa-aec0-898d4750b064@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).