From: Zorro Lang <zlang@redhat.com>
To: Chen Hanxiao <chenhx.fnst@fujitsu.com>
Cc: fstests@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH fstests] generic/742: don't run it on NFS
Date: Thu, 16 May 2024 11:49:53 +0800 [thread overview]
Message-ID: <20240516034953.7im5grlfdr2xzs7e@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> (raw)
In-Reply-To: <20240515092133.1219-1-chenhx.fnst@fujitsu.com>
On Wed, May 15, 2024 at 05:21:33PM +0800, Chen Hanxiao wrote:
> This test requires FIEMAP support.
>
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
> tests/generic/742 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/742 b/tests/generic/742
> index 43ebdbc6..aad57f2d 100755
> --- a/tests/generic/742
> +++ b/tests/generic/742
> @@ -30,6 +30,7 @@ _require_test
> _require_test_program "fiemap-fault"
> _require_test_program "punch-alternating"
> _require_xfs_io_command "fpunch"
> +_require_xfs_io_command "fiemap"
Make sense to me. But according the change, I'd like to change the subject
from "don't run it on NFS" to "require fiemap support", due to it's not
only for NFS.
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> dst=$TEST_DIR/$seq/fiemap-fault
>
> --
> 2.43.0
>
>
prev parent reply other threads:[~2024-05-16 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 9:21 [PATCH fstests] generic/742: don't run it on NFS Chen Hanxiao
2024-05-16 3:49 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516034953.7im5grlfdr2xzs7e@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com \
--to=zlang@redhat.com \
--cc=chenhx.fnst@fujitsu.com \
--cc=fstests@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).