From: Zorro Lang <zlang@redhat.com>
To: David Disseldorp <ddiss@suse.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] common/config: export TEST_DEV for mkfs.xfs
Date: Mon, 29 Apr 2024 21:37:11 +0800 [thread overview]
Message-ID: <20240429133711.rny3rzweegx66nj3@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> (raw)
In-Reply-To: <20240429212845.0094c51c@echidna>
On Mon, Apr 29, 2024 at 09:28:45PM +1000, David Disseldorp wrote:
> On Sun, 28 Apr 2024 13:37:17 +0800, Zorro Lang wrote:
>
> > On Thu, Apr 11, 2024 at 04:32:33PM +1000, David Disseldorp wrote:
> > > As of xfsprogs commit 6e0ed3d1 ("mkfs: stop allowing tiny filesystems")
> > > attempts to create XFS filesystems sized under 300M fail, unless
> > > TEST_DIR, TEST_DEV and QA_CHECK_FS environment variables are exported
> > > (or a --unsupported mkfs parameter is provided).
> > >
> > > TEST_DIR and QA_CHECK_FS are already exported, while TEST_DEV may only
> > > be locally set if provided via e.g. configs/$HOSTNAME.config. Explicitly
> > > export TEST_DEV to ensure that tests which call _scratch_mkfs_sized()
> > > with an fssize under 300M run normally.
> > >
> > > Signed-off-by: David Disseldorp <ddiss@suse.de>
> > > ---
> >
> > Actually, using "export" in xfstests/local.config for each parameter could
> > help too.
> >
> > The 2nd patch still has some disagreement, I'll merge this patch at first,
> > as it's simple enough and got two RVBs.
>
> Thanks. I'll send an updated 2/2 today following Darrick's suggestion of
> _try_scratch_mkfs_sized $* || _fail
Thanks for doing it :)
I'm wondering if we could change all _scratch_mkfs and _scratch_mkfs_xxx helpers
like that. But we can change _scratch_mkfs_sized at first, then other _scratch_mkfs_xxx
helpers, then _scratch_mkfs itself.
At the same time, please don't forgot those cases do "_scratch_mkfs_xxx ... | _fail ...".
Thanks,
Zorro
>
prev parent reply other threads:[~2024-04-29 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 6:32 [PATCH 1/2] common/config: export TEST_DEV for mkfs.xfs David Disseldorp
2024-04-11 6:32 ` [PATCH 2/2] tests: _fail on _scratch_mkfs_sized failure David Disseldorp
2024-04-12 15:48 ` Darrick J. Wong
2024-04-12 19:28 ` Zorro Lang
2024-04-27 5:58 ` Christoph Hellwig
2024-04-12 15:44 ` [PATCH 1/2] common/config: export TEST_DEV for mkfs.xfs Darrick J. Wong
2024-04-27 5:56 ` Christoph Hellwig
2024-04-28 5:37 ` Zorro Lang
2024-04-29 11:28 ` David Disseldorp
2024-04-29 13:37 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429133711.rny3rzweegx66nj3@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com \
--to=zlang@redhat.com \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).