From: Zorro Lang <zlang@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Yong Sun <yosun@suse.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: solve no-return-in-nonvoid-function issue
Date: Sat, 27 Apr 2024 16:41:40 +0800 [thread overview]
Message-ID: <20240427084140.6eaalb3tsoe3o35a@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> (raw)
In-Reply-To: <ZiySu-TX-5kR3VOx@infradead.org>
On Fri, Apr 26, 2024 at 10:52:59PM -0700, Christoph Hellwig wrote:
> On Wed, Apr 24, 2024 at 07:24:08PM +0800, Yong Sun wrote:
> > --- a/src/fake-dump-rootino.c
> > +++ b/src/fake-dump-rootino.c
> > @@ -221,4 +221,5 @@ int main(int argc, char *argv[]) {
> >
> > munmap(header, GLOBAL_HDR_SZ);
> > close(fd);
> > + return 0;
>
> This needs to use a tab instead of spaces. Otherwise looks good:
Yes, I'll help to change that, thanks!
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
prev parent reply other threads:[~2024-04-27 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 11:24 [PATCH] fstests: solve no-return-in-nonvoid-function issue Yong Sun
2024-04-27 5:52 ` Christoph Hellwig
2024-04-27 8:41 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240427084140.6eaalb3tsoe3o35a@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=yosun@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).