From: "Theodore Ts'o" <tytso@mit.edu>
To: "Luis Henriques (SUSE)" <luis.henriques@linux.dev>
Cc: "Darrick J . Wong" <djwong@kernel.org>, fstests@vger.kernel.org
Subject: Re: [PATCH v2] ext4/01{2,9}: fix invalid filesystem option 'journal'
Date: Mon, 1 Apr 2024 12:56:13 -0400 [thread overview]
Message-ID: <20240401165613.GA2046915@mit.edu> (raw)
In-Reply-To: <20240401095709.12304-1-luis.henriques@linux.dev>
On Mon, Apr 01, 2024 at 10:57:08AM +0100, Luis Henriques (SUSE) wrote:
> Creating an ext4 filesystem using '-O journal' will fail with:
>
> Invalid filesystem option set: journal
>
> Fix it by replacing it by '-O has_journal', which ensures the filesystem
> (ext3 or ext4) is created with a journal. While there, also redirect stderr
> and stdout to the full log.
>
> Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2024-04-01 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 9:57 [PATCH v2] ext4/01{2,9}: fix invalid filesystem option 'journal' Luis Henriques (SUSE)
2024-04-01 14:55 ` Darrick J. Wong
2024-04-01 16:56 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240401165613.GA2046915@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=luis.henriques@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).