FSTests Archive mirror
 help / color / mirror / Atom feed
From: "Luis Henriques (SUSE)" <luis.henriques@linux.dev>
To: fstests@vger.kernel.org
Cc: "Darrick J . Wong" <djwong@kernel.org>,
	"Luis Henriques (SUSE)" <luis.henriques@linux.dev>
Subject: [PATCH v2 0/2] Ensure _scratch_fuzz_modify() works for other filesystems
Date: Fri, 15 Mar 2024 17:13:23 +0000	[thread overview]
Message-ID: <20240315171325.2885-1-luis.henriques@linux.dev> (raw)

Hi!

I guess test ext4/006 isn't executed very often, because as far as I can see
it has been broken for quite some time.  The problem is that the function
_scratch_fuzz_modify() is executing xfs-specific operations that will make
this test fail.

The first patch updates this function so that xfs-specific operations are
executed only when that filesystem is being tested.

The second patch simply updates the test to take into account the new output
of the function (and yeah, counting log lines is an ugly hack).

Changes since v1:
* Updated the second patch commit message to add further details on what
  changed with the test output.

Luis Henriques (SUSE) (2):
  common/fuzzy: make _scratch_fuzz_modify work for non-xfs filesystems
  ext4/006: take into account updates to _scratch_fuzz_modify()

 common/fuzzy   | 16 +++++++++-------
 tests/ext4/006 |  2 +-
 2 files changed, 10 insertions(+), 8 deletions(-)


             reply	other threads:[~2024-03-15 17:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15 17:13 Luis Henriques (SUSE) [this message]
2024-03-15 17:13 ` [PATCH v2 1/2] common/fuzzy: make _scratch_fuzz_modify work for non-xfs filesystems Luis Henriques (SUSE)
2024-03-20  1:20   ` Darrick J. Wong
2024-03-15 17:13 ` [PATCH v2 2/2] ext4/006: take into account updates to _scratch_fuzz_modify() Luis Henriques (SUSE)
2024-03-20  1:21   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240315171325.2885-1-luis.henriques@linux.dev \
    --to=luis.henriques@linux.dev \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).