From: "Darrick J. Wong" <djwong@kernel.org>
To: Luis Henriques <luis.henriques@linux.dev>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4/006: take into account updates to _scratch_fuzz_modify()
Date: Fri, 15 Mar 2024 08:37:27 -0700 [thread overview]
Message-ID: <20240315153727.GI6188@frogsfrogsfrogs> (raw)
In-Reply-To: <87le6j7tbv.fsf@brahms.olymp>
On Fri, Mar 15, 2024 at 09:11:32AM +0000, Luis Henriques wrote:
> "Darrick J. Wong" <djwong@kernel.org> writes:
>
> > On Thu, Mar 14, 2024 at 05:25:12PM +0000, Luis Henriques (SUSE) wrote:
> >> Since function _scratch_fuzz_modify() has been updated, its output has
> >> changed. Modify test ext4/006 to take this change into account.
> >
> > Now that you've blocked off the XFS stuff, what line changed?
>
> Well, there are three lines that are gone with commit 9bab148bb3c7:
>
> echo "+++ touch ${nr} files"
> echo "+++ create files"
> echo "+++ remove files"
>
> And a new one was added:
>
> echo "+++ stressing filesystem"
>
> However, running fsstress will also add a new line with:
>
> printf("seed = %ld\n", seed);
>
> So the delta is one line (seven instead of eight).
Ah, ok. Can you copy-paste that into the commit message so that we have
some record of what caused the need for the adjustment, please?
With that added,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> Cheers,
> --
> Luís
>
> >
> > --D
> >
> >> Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
> >> ---
> >> tests/ext4/006 | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/ext4/006 b/tests/ext4/006
> >> index 8792167bd9c2..b73692aa5b81 100755
> >> --- a/tests/ext4/006
> >> +++ b/tests/ext4/006
> >> @@ -131,7 +131,7 @@ echo "++ check fs (2)" >> $seqres.full
> >> _check_scratch_fs >> $seqres.full 2>&1
> >>
> >> grep -E -q '(did not fix|makes no progress)' $seqres.full && echo "e2fsck failed" | tee -a $seqres.full
> >> -if [ "$(wc -l < "$ROUND2_LOG")" -ne 8 ]; then
> >> +if [ "$(wc -l < "$ROUND2_LOG")" -ne 7 ]; then
> >> echo "e2fsck did not fix everything" | tee -a $seqres.full
> >> fi
> >> echo "finished fuzzing" | tee -a "$seqres.full"
> >>
>
prev parent reply other threads:[~2024-03-15 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 17:25 [PATCH 0/2] Ensure _scratch_fuzz_modify() works for other filesystems Luis Henriques (SUSE)
2024-03-14 17:25 ` [PATCH 1/2] common/fuzzy: make _scratch_fuzz_modify work for non-xfs filesystems Luis Henriques (SUSE)
2024-03-15 2:49 ` Darrick J. Wong
2024-03-14 17:25 ` [PATCH 2/2] ext4/006: take into account updates to _scratch_fuzz_modify() Luis Henriques (SUSE)
2024-03-15 2:51 ` Darrick J. Wong
2024-03-15 9:11 ` Luis Henriques
2024-03-15 15:37 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315153727.GI6188@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=luis.henriques@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).