FSTests Archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: zlang@kernel.org
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH] generic/449: don't run with RT devices
Date: Wed, 21 Feb 2024 07:35:24 +0100	[thread overview]
Message-ID: <20240221063524.3562890-1-hch@lst.de> (raw)

generic/449 tests of xattr behavior when we run out of disk space for
xattrs which are on the main device, but _scratch_mkfs_sized will control
the size of the RT device.

Skip it when a RT device is in used, as otherwise it won't test what it
is supposed to while taking a long time to fill the unrestricted data
device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/449 | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/generic/449 b/tests/generic/449
index 2b77a6a49..4269703f6 100755
--- a/tests/generic/449
+++ b/tests/generic/449
@@ -24,14 +24,15 @@ _require_test
 _require_acls
 _require_attrs trusted
 
+# This is a test of xattr behavior when we run out of disk space for xattrs,
+# but _scratch_mkfs_sized will control the size of the RT device.  Skip it
+# when a RT device is in used, as otherwise it won't test what it is supposed
+# to while taking a long time to fill the unrestricted data device
+_require_no_realtime
+
 _scratch_mkfs_sized $((256 * 1024 * 1024)) >> $seqres.full 2>&1
 _scratch_mount || _fail "mount failed"
 
-# This is a test of xattr behavior when we run out of disk space for xattrs,
-# so make sure the pwrite goes to the data device and not the rt volume.
-test "$FSTYP" = "xfs" && \
-	_xfs_force_bdev data $SCRATCH_MNT
-
 TFILE=$SCRATCH_MNT/testfile.$seq
 
 # Create the test file and choose its permissions
-- 
2.39.2


             reply	other threads:[~2024-02-21  6:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21  6:35 Christoph Hellwig [this message]
2024-02-21 15:53 ` [PATCH] generic/449: don't run with RT devices Darrick J. Wong
2024-02-21 16:25   ` Christoph Hellwig
2024-02-21 17:13     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240221063524.3562890-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).