From: Su Yue <glass.su@suse.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, l@damenly.org, Su Yue <glass.su@suse.com>
Subject: [PATCH] btrfs/172,206: call _log_writes_cleanup in _cleanup
Date: Thu, 15 Feb 2024 22:02:36 +0800 [thread overview]
Message-ID: <20240215140236.29171-1-l@damenly.org> (raw)
From: Su Yue <glass.su@suse.com>
Because block group tree requires require no-holes feature,
_log_writes_mkfs "-O ^no-holes" fails when "-O block-group-tree" is
given in MKFS_OPTION.
Without explicit _log_writes_cleanup, the two tests fail with
logwrites-test device left. And all next tests will fail due to
SCRATCH DEVICE EBUSY.
Fix it by overriding _cleanup to call _log_writes_cleanup.
Signed-off-by: Su Yue <glass.su@suse.com>
---
tests/btrfs/172 | 6 ++++++
tests/btrfs/206 | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/tests/btrfs/172 b/tests/btrfs/172
index f5acc6982cd7..fceff56c9d37 100755
--- a/tests/btrfs/172
+++ b/tests/btrfs/172
@@ -13,6 +13,12 @@
. ./common/preamble
_begin_fstest auto quick log replay recoveryloop
+# Override the default cleanup function.
+_cleanup()
+{
+ _log_writes_cleanup &> /dev/null
+}
+
# Import common functions.
. ./common/filter
. ./common/dmlogwrites
diff --git a/tests/btrfs/206 b/tests/btrfs/206
index f6571649076f..e05adf75b67e 100755
--- a/tests/btrfs/206
+++ b/tests/btrfs/206
@@ -14,6 +14,12 @@
. ./common/preamble
_begin_fstest auto quick log replay recoveryloop punch prealloc
+# Override the default cleanup function.
+_cleanup()
+{
+ _log_writes_cleanup &> /dev/null
+}
+
# Import common functions.
. ./common/filter
. ./common/dmlogwrites
--
2.43.0
next reply other threads:[~2024-02-15 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 14:02 Su Yue [this message]
2024-02-15 15:58 ` [PATCH] btrfs/172,206: call _log_writes_cleanup in _cleanup Filipe Manana
2024-02-15 23:10 ` Qu Wenruo
2024-03-01 13:49 ` Zorro Lang
2024-03-01 14:55 ` Filipe Manana
2024-03-02 7:03 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215140236.29171-1-l@damenly.org \
--to=glass.su@suse.com \
--cc=fstests@vger.kernel.org \
--cc=l@damenly.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).