From: "Darrick J. Wong" <djwong@kernel.org>
To: Anthony Iliopoulos <ailiop@suse.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] src/af_unix: drop unused offsetof macro definition
Date: Fri, 12 Jan 2024 09:00:56 -0800 [thread overview]
Message-ID: <20240112170056.GF722968@frogsfrogsfrogs> (raw)
In-Reply-To: <20240112130331.4079-1-ailiop@suse.com>
On Fri, Jan 12, 2024 at 02:03:31PM +0100, Anthony Iliopoulos wrote:
> The offsetof macro is causing compiler warnings since it is being
> redefined, but it is anyway not used, so drop it completely.
>
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> src/af_unix.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/af_unix.c b/src/af_unix.c
> index 41037ee4b7ad..89df76586f27 100644
> --- a/src/af_unix.c
> +++ b/src/af_unix.c
> @@ -17,8 +17,6 @@
> #include <sys/socket.h>
> #include <sys/un.h>
>
> -#define offsetof(TYPE, MEMBER) ((size_t)&((TYPE *)0)->MEMBER)
> -
> int main(int argc, char *argv[])
> {
> struct sockaddr_un sun;
> --
> 2.41.0
>
>
prev parent reply other threads:[~2024-01-12 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 13:03 [PATCH] src/af_unix: drop unused offsetof macro definition Anthony Iliopoulos
2024-01-12 17:00 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112170056.GF722968@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=ailiop@suse.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).