From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: Petr Vorel <pvorel@suse.cz>, Cyril Hrubis <chrubis@suse.cz>,
Li Wang <liwang@redhat.com>, Jan Stancek <jstancek@redhat.com>,
Xiao Yang <yangx.jy@fujitsu.com>,
Yang Xu <xuyang2018.jy@fujitsu.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Brian Foster <bfoster@redhat.com>,
linux-bcachefs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 1/1] safe_macros: Fix bcachefs failure old kernel
Date: Thu, 11 Jan 2024 16:05:53 +0100 [thread overview]
Message-ID: <20240111150553.1923767-1-pvorel@suse.cz> (raw)
LTP with bcachefs-tools and kernel < 6.7 fails (more tests):
# LTP_SINGLE_FS_TYPE=bcachefs ./chdir01
...
tst_supported_fs_types.c:57: TINFO: mkfs.bcachefs does exist
tst_test.c:1669: TINFO: === Testing on bcachefs ===
tst_test.c:1117: TINFO: Formatting /dev/loop0 with bcachefs opts=''
extra opts=''
tst_test.c:1131: TINFO: Mounting /dev/loop0 to
/tmp/LTP_chdwqhGtZ/mntpoint fstyp=bcachefs flags=0
tst_test.c:1131: TBROK: mount(/dev/loop0, mntpoint, bcachefs, 0, (nil))
failed: ENODEV (19)
The problem is that on FUSE support we expect there is FUSE bcachefs
implementation. bcachefs supports fusemount, but let's skip testing atm.
Fixes: 94802606e ("lib: Add support bcachefs filesystem to .all_filesystems")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi all,
I'm sorry, although man bcachefs(8) mentions fusemount, I haven't
figured out how to mount filesystem. Am I missing something?
Also, maybe for the start I would prefer to to test just kernel
functionality (no fuse).
Kind regards,
Petr
lib/tst_supported_fs_types.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/tst_supported_fs_types.c b/lib/tst_supported_fs_types.c
index 369836717..21765c370 100644
--- a/lib/tst_supported_fs_types.c
+++ b/lib/tst_supported_fs_types.c
@@ -96,6 +96,11 @@ static enum tst_fs_impl has_kernel_support(const char *fs_type)
SAFE_RMDIR(template);
+ if (!strcmp(fs_type, "bcachefs") && tst_kvercmp(6, 7, 0) < 0) {
+ tst_res(TINFO, "bcachefs skipped on kernel < 6.7");
+ return TST_FS_UNSUPPORTED;
+ }
+
/* Is FUSE supported by kernel? */
if (fuse_supported == -1) {
ret = open("/dev/fuse", O_RDWR);
--
2.43.0
next reply other threads:[~2024-01-11 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 15:05 Petr Vorel [this message]
2024-01-11 15:13 ` [PATCH 1/1] safe_macros: Fix bcachefs failure old kernel pvorel
2024-01-17 16:01 ` Cyril Hrubis
2024-01-17 20:53 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111150553.1923767-1-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=bfoster@redhat.com \
--cc=chrubis@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=jstancek@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).