From: Anand Jain <anand.jain@oracle.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Zorro Lang <zlang@redhat.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"fdmanana@suse.com" <fdmanana@suse.com>
Subject: Re: [PATCH v3 3/3] fstests: btrfs: check conversion of zoned fileystems
Date: Wed, 28 Feb 2024 15:22:44 +0530 [thread overview]
Message-ID: <1c05fac2-006d-4518-9eb3-4ed8e2f4f905@oracle.com> (raw)
In-Reply-To: <c56b927a-8ea7-4406-a5c9-12a61471c91f@wdc.com>
On 2/27/24 23:04, Johannes Thumshirn wrote:
> On 27.02.24 14:12, Zorro Lang wrote:
>> On Thu, Feb 15, 2024 at 03:47:06AM -0800, Johannes Thumshirn wrote:
>>> Recently we had a bug where a zoned filesystem could be converted to a
>>> higher data redundancy profile than supported.
>>>
>>> Add a test-case to check the conversion on zoned filesystems.
>>>
>>> Reviewed-by: Filipe Manana <fdmanana@suse.com>
>>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>>> ---
>>> tests/btrfs/310 | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>> tests/btrfs/310.out | 12 ++++++++++
>>> 2 files changed, 79 insertions(+)
>>>
>>> diff --git a/tests/btrfs/310 b/tests/btrfs/310
>>> new file mode 100755
>>> index 000000000000..c39f60168f8a
>>> --- /dev/null
>>> +++ b/tests/btrfs/310
>>> @@ -0,0 +1,67 @@
>>> +#! /bin/bash
>>> +# SPDX-License-Identifier: GPL-2.0
>>> +# Copyright (c) 2024 Western Digital Corporation. All Rights Reserved.
>>> +#
>>> +# FS QA Test 310
>>> +#
>>> +# Test that btrfs convert can ony be run to convert to supported profiles on a
>>> +# zoned filesystem
>>> +#
>>> +. ./common/preamble
>>> +_begin_fstest volume raid convert
>>
>> Don't you want to add it in "auto" group, to be a default test?
>
> Actually I do and forgot about it, sorry.
>
I missed it too. I'll add it before the PR. I've updated the
mkfs as Zorro suggests.
----------
<snap>
+_begin_fstest auto volume raid convert
<snap>
+_scratch_mkfs -msingle -dsingle 2>&1 >> $seqres.full || _fail "mkfs failed"
<snap>
----------
Thanks, Anand
next prev parent reply other threads:[~2024-02-28 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 11:47 [PATCH v3 0/3] fstests: btrfs: add test for zoned balance profile conversion bug Johannes Thumshirn
2024-02-15 11:47 ` [PATCH v3 1/3] filter.brtfs: add filter for conversion Johannes Thumshirn
2024-02-15 11:47 ` [PATCH v3 2/3] filter.btrfs: add filter for btrfs device add Johannes Thumshirn
2024-02-26 17:16 ` Anand Jain
2024-02-27 11:18 ` Johannes Thumshirn
2024-02-27 12:01 ` Anand Jain
2024-02-15 11:47 ` [PATCH v3 3/3] fstests: btrfs: check conversion of zoned fileystems Johannes Thumshirn
2024-02-27 13:12 ` Zorro Lang
2024-02-27 17:34 ` Johannes Thumshirn
2024-02-28 9:52 ` Anand Jain [this message]
2024-02-26 11:53 ` [PATCH v3 0/3] fstests: btrfs: add test for zoned balance profile conversion bug Johannes Thumshirn
2024-02-26 12:52 ` Anand Jain
2024-02-27 13:14 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c05fac2-006d-4518-9eb3-4ed8e2f4f905@oracle.com \
--to=anand.jain@oracle.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).