From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Anand Jain <anand.jain@oracle.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>
Cc: Zorro Lang <zlang@redhat.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH v2] fstests: btrfs: check conversion of zoned fileystems
Date: Thu, 15 Feb 2024 10:56:03 +0000 [thread overview]
Message-ID: <02e52e02-395e-4fff-a3bf-c594965fcaa4@wdc.com> (raw)
In-Reply-To: <02dadc0b-85af-47ae-8cf2-e1289c521aaa@oracle.com>
On 13.02.24 09:46, Anand Jain wrote:
>
>
> On 2/13/24 13:50, Johannes Thumshirn wrote:
>> Recently we had a bug where a zoned filesystem could be converted to a
>> higher data redundancy profile than supported.
>>
>> Add a test-case to check the conversion on zoned filesystems.
>>
>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>> Reviewed-by: Filipe Manana <fdmanana@suse.com>
>> ---
>> tests/btrfs/310 | 75 +++++++++++++++++++++++++++++++++++++++++++++
>> tests/btrfs/310.out | 12 ++++++++
>> 2 files changed, 87 insertions(+)
>> create mode 100755 tests/btrfs/310
>> create mode 100644 tests/btrfs/310.out
>>
>> diff --git a/tests/btrfs/310 b/tests/btrfs/310
>> new file mode 100755
>> index 00000000..6b0846f0
>> --- /dev/null
>> +++ b/tests/btrfs/310
>> @@ -0,0 +1,75 @@
>> +#! /bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +# Copyright (c) 2024 Western Digital Corporation. All Rights Reserved.
>> +#
>> +# FS QA Test 310
>> +#
>> +# Test that btrfs convert can ony be run to convert to supported profiles on a
>> +# zoned filesystem
>> +#
>> +. ./common/preamble
>> +_begin_fstest volume raid convert
>> +
>> +_fixed_by_kernel_commit XXXXXXXXXX \
>> + "btrfs: zoned: don't skip block group profile checks on conv zones"
>> +
>
>> +. common/filter
>> +. common/filter.btrfs
>
> common/filter.btrfs includes common/filter;
> So common/filter can be dropped.
Sure.
>
>> +
>> +_supported_fs btrfs
>> +_require_scratch_dev_pool 4
>
>> +_require_zoned_device "$SCRATCH_DEV"
>
> So, only the first device has to be a zone device?
Nope, but _require_zoned_device only accepts a single device ATM and if
device 1 is a zoned device, the FS is zoend, so adding non zoned devices
will treat them as zoned devices using the zone emulation layer. So I
think it is fine.
>
>> +
>> +
>> +_filter_convert()
>> +{
>> + _filter_scratch | \
>> + sed -e "s/relocate [0-9]\+ out of [0-9]\+ chunks/relocate X out of X chunks/g"
>> +}
>> +
>> +_filter_add()
>> +{
>> + _filter_scratch | _filter_scratch_pool | \
>> + sed -e "s/Resetting device zones SCRATCH_DEV ([0-9]\+/Resetting device zones SCRATCH_DEV (XXX/g"
>> +
>> +}
>> +
>
> Can we add the prefix 'balance' to these functions since they filter
> the balance output? Also, imo, it is better to move them to
> filter.btrfs.
>
Sure.
> and..
>
>> +devs=( $SCRATCH_DEV_POOL )
>> +
>> +# Create and mount single device FS
>> +_scratch_mkfs -msingle -dsingle 2>&1 > /dev/null
>> +_scratch_mount
>> +
>> +# Convert FS to metadata/system DUP
>> +$BTRFS_UTIL_PROG balance start -f -mconvert=dup -sconvert=dup $SCRATCH_MNT 2>&1 | _filter_convert
>> +
>
> Why not update _run_btrfs_balance_start() to support argument passing
> and pass the options to it to run balance using the helper function?
>
I'll look into it.
prev parent reply other threads:[~2024-02-15 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 8:20 [PATCH v2] fstests: btrfs: check conversion of zoned fileystems Johannes Thumshirn
2024-02-13 8:46 ` Anand Jain
2024-02-15 10:56 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02e52e02-395e-4fff-a3bf-c594965fcaa4@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=anand.jain@oracle.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).