From: Vincent Fu <vincentfu@gmail.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
fio@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH] stat: Fix ioprio print
Date: Wed, 15 Mar 2023 19:26:34 -0400 [thread overview]
Message-ID: <db711a58-ed95-ba93-2838-783027bd9b0b@gmail.com> (raw)
In-Reply-To: <20230310012839.9532-1-damien.lemoal@opensource.wdc.com>
On 3/9/23 20:28, Damien Le Moal wrote:
> When using per-priority statistics for workloads using multiple
> different priority values, the statistics output displays the priority
> class and value (level) for each set of statistics. However, this is
> done using linux priority values coding, that is, assuming that the
> priority level is at most 7 (lower 3-bits). However, this is not always
> the case for all OSes. E.g. dragonfly allows IO priorities up to a
> value of 10.
>
> Introduce the OS dependent ioprio_class() and ioprio() macros to extract
> the fields from an ioprio value according to the OS capabilities. A
> generic definition (always returning 0) for these macros in os/os.h is
> added and used for all OSes that do not define these macros.
>
> The functions show_ddir_status() and add_ddir_status_json() are modified
> to use these new macros to fix per priority statistics output. The
> modification includes changes to the loops over the clat_prio array to
> reduce indentation levels, making the code a little cleaner.
>
> Fixes: 692dec0cfb4b ("stat: report clat stats on a per priority granularity")
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
Applied. Thanks.
Vincent
prev parent reply other threads:[~2023-03-15 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 1:28 [PATCH] stat: Fix ioprio print Damien Le Moal
2023-03-10 13:20 ` Niklas Cassel
2023-03-15 23:26 ` Vincent Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db711a58-ed95-ba93-2838-783027bd9b0b@gmail.com \
--to=vincentfu@gmail.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=fio@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).