From: Vincent Fu <vincentfu@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Ankit Kumar <ankit.kumar@samsung.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH 1/2] stat: log out both average and max over the window
Date: Mon, 22 Jan 2024 14:55:57 -0500 [thread overview]
Message-ID: <daae86e3-5b80-4990-a30d-4924d52f1e39@gmail.com> (raw)
In-Reply-To: <6f3a1f7e-29cd-4e58-af00-9d1be93261b3@kernel.dk>
On 1/22/24 13:17, Jens Axboe wrote:
> On 1/22/24 4:22 AM, Ankit Kumar wrote:
>> Modify option log_max_value to report average, max or both the values, by
>> setting it to 0, 1 or 2 respectively. There is no change to existing log
>> formats while reporting only average or max values.
>
> That would be much cleaner as a posval instead, where it takes a textual
> description rather than magic 0/1/2 values.
>
You could do what was done for continue_on_error, which it seems was
also originally a boolean that was later expanded to have other possible
values.
Maybe even change the name of this option to something like
"log_lat_value" and retain the original name as an alias.
Vincent
next prev parent reply other threads:[~2024-01-22 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240122060524epcas5p1ef9946a897a9a25b6b89072f01fdc924@epcas5p1.samsung.com>
2024-01-22 11:22 ` [PATCH 0/2] log both average and max values over the window Ankit Kumar
[not found] ` <CGME20240122060525epcas5p17d417303b27a454e1db288a61e0642fc@epcas5p1.samsung.com>
2024-01-22 11:22 ` [PATCH 1/2] stat: log out both average and max " Ankit Kumar
2024-01-22 18:17 ` Jens Axboe
2024-01-22 19:55 ` Vincent Fu [this message]
[not found] ` <CGME20240122060526epcas5p21030269f7690010a4cb98b7ce4e3b729@epcas5p2.samsung.com>
2024-01-22 11:23 ` [PATCH 2/2] docs: update fio man page for log_max_value Ankit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daae86e3-5b80-4990-a30d-4924d52f1e39@gmail.com \
--to=vincentfu@gmail.com \
--cc=ankit.kumar@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).