From: Avri Altman <Avri.Altman@wdc.com>
To: Vincent Fu <vincentfu@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Vincent Fu <vincent.fu@samsung.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: RE: [PATCH 5/6] t/jobs: Fix a typo in jobs 23 & 24
Date: Sat, 2 Mar 2024 19:18:09 +0000 [thread overview]
Message-ID: <DM6PR04MB657556231E3AC0D75AB3DFEDFC5D2@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <d3f51807-8793-4e90-a0f6-28d7e114d910@gmail.com>
> On 3/2/24 03:36, Avri Altman wrote:
> > s/bsrange/bssplit
> >
> > Fixes: commit c37183f8a161 (test: test job for randtrimwrite)
> > Signed-off-by: Avri Altman <avri.altman@wdc.com>
> > ---
> > t/jobs/t0023.fio | 4 ++--
> > t/jobs/t0024.fio | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/t/jobs/t0023.fio b/t/jobs/t0023.fio index
> > 4f0bef89..b051fef2 100644
> > --- a/t/jobs/t0023.fio
> > +++ b/t/jobs/t0023.fio
> > @@ -33,7 +33,7 @@ bsrange=512-4k
> > # block sizes match
> > # Buggy result: something else
> > [bssplit]
> > -bsrange=512/25:1k:25:2k:25:4k/25
> > +bssplit=512/25:1k/:2k/:/4k
>
> Thanks for catching this issue.
>
> The end of the line above should be 4k/ instead of /4k
>
> https://github.com/fiotestbot/fio/actions/runs/8121755928
Thanks. Will fix in v2.
Thanks,
Avri
>
> >
> > # Expected result: trim issued to random offset followed by write to same
> offset
> > # block sizes match
> > @@ -59,5 +59,5 @@ norandommap=1
> > # block sizes match
> > # Buggy result: something else
> > [bssplit_no_rm]
> > -bsrange=512/25:1k:25:2k:25:4k/25
> > +bssplit=512/25:1k/:2k/:4k/
> > norandommap=1
> > diff --git a/t/jobs/t0024.fio b/t/jobs/t0024.fio index
> > 393a2b70..2b3dc94c 100644
> > --- a/t/jobs/t0024.fio
> > +++ b/t/jobs/t0024.fio
> > @@ -33,4 +33,4 @@ bsrange=512-4k
> > # block sizes match
> > # Buggy result: something else
> > [bssplit]
> > -bsrange=512/25:1k:25:2k:25:4k/25
> > +bssplit=512/25:1k/:2k/:4k/
next prev parent reply other threads:[~2024-03-02 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 8:36 [PATCH 0/6] Some minor cleanups Avri Altman
2024-03-02 8:36 ` [PATCH 1/6] fio: Some minor code cleanups Avri Altman
2024-03-02 8:36 ` [PATCH 2/6] t/jobs: Further clarify regression test 7 Avri Altman
2024-03-02 8:36 ` [PATCH 3/6] t/jobs: Further clarify regression test 8 Avri Altman
2024-03-02 8:36 ` [PATCH 4/6] t/jobs: Rename test job 15 Avri Altman
2024-03-02 8:36 ` [PATCH 5/6] t/jobs: Fix a typo in jobs 23 & 24 Avri Altman
2024-03-02 12:42 ` Vincent Fu
2024-03-02 19:18 ` Avri Altman [this message]
2024-03-02 8:36 ` [PATCH 6/6] Doc: Make note of using bsrange with ':' Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB657556231E3AC0D75AB3DFEDFC5D2@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincent.fu@samsung.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).