From: Jens Axboe <axboe@kernel.dk>
To: Vincent Fu <vincentfu@gmail.com>, Ankit Kumar <ankit.kumar@samsung.com>
Cc: fio@vger.kernel.org, joshi.k@samsung.com
Subject: Re: [PATCH 1/1] engines/io_uring: io_uring_cmd engine cleanup and fixes
Date: Fri, 12 May 2023 12:32:46 -0600 [thread overview]
Message-ID: <5dfd99af-bd44-4d55-fbbe-1b0a68ee9b15@kernel.dk> (raw)
In-Reply-To: <a91da230-b6ad-8177-37e1-0b7d3b8aead3@gmail.com>
On 5/12/23 10:47?AM, Vincent Fu wrote:
> On 5/8/23 12:01, Ankit Kumar wrote:
>> - The io_uring_cmd ioengine assumes that logical block size is power of 2.
>> In case of extended LBA where metadata is transferred as part of LBA
>> this is not correct. Use division operation for that. The existing
>> calculation for power of 2 LBA remains the same.
>>
>> - The current implementation doesn't support protection info and
>> metadata transferred as separate buffer, return error for these
>> scenarios.
>>
>> - Add checks to verify that block sizes are multiple of LBA size.
>> - Add support for 64 LBA formats as per the latest NVM command set
>> specification.
>>
>> Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
>
> Ankit, overall this looks fine.
>
> Consider splitting this patch into two separate ones:
>
> 1) add support for extended LBA sizes
> 2) add support for more than 16 LBA formats
Exactly, that was going to be my comment too. If you need to make
paragraphs on what changes are being made, that's a clear sign that they
should be separate changes.
--
Jens Axboe
prev parent reply other threads:[~2023-05-12 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230508104106epcas5p30f01a4afec7405be8f46f99b73fa9207@epcas5p3.samsung.com>
2023-05-08 16:01 ` [PATCH 0/1] io_uring_cmd engine extende LBA fixes and cleanup Ankit Kumar
[not found] ` <CGME20230508104107epcas5p1f66b2d5c59293d9d902502e23add5c73@epcas5p1.samsung.com>
2023-05-08 16:01 ` [PATCH 1/1] engines/io_uring: io_uring_cmd engine cleanup and fixes Ankit Kumar
2023-05-12 16:47 ` Vincent Fu
2023-05-12 18:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dfd99af-bd44-4d55-fbbe-1b0a68ee9b15@kernel.dk \
--to=axboe@kernel.dk \
--cc=ankit.kumar@samsung.com \
--cc=fio@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).