From: Vincent Fu <vincentfu@gmail.com>
To: Ankit Kumar <ankit.kumar@samsung.com>, axboe@kernel.dk
Cc: fio@vger.kernel.org
Subject: Re: [PATCH v3 0/2] log both average and max values over the window
Date: Thu, 25 Jan 2024 09:11:59 -0500 [thread overview]
Message-ID: <2830529c-c441-4047-8bf5-02698d3fbb05@gmail.com> (raw)
In-Reply-To: <20240125110124.55137-1-ankit.kumar@samsung.com>
On 1/25/24 06:01, Ankit Kumar wrote:
> This series adds an alias log_window_value to option log_max_value which
> now report average, max or both the values. The log_window_value option
> type has been changed from boolean to string but retains backward
> compatibility by allowing =0 and =1 values to specify avg and max values
> respectively.
> There is no change to existing log formats while reporting only average
> or max values.
>
> The fio documentation has been updated specifying the new log format
> when both values are reported.
>
> Changes since v2:
> - Fix man page as suggested by Vincent.
>
> Changes since v1:
> - Use posval for strings instead of magic numbers as suggested by
> Jens.
> - Change option name to log_window_value and add alias to log_max_value
> as suggested by Vincent.
>
> Ankit Kumar (2):
> stat: log out both average and max over the window
> docs: update fio man page for log_window_value
>
> HOWTO.rst | 45 +++++++++++++++++++++++++--------
> client.c | 6 +++--
> fio.1 | 47 +++++++++++++++++++++++++++--------
> iolog.c | 74 ++++++++++++++++++++++++++++++++++++++++---------------
> iolog.h | 21 +++++++++++++---
> options.c | 34 +++++++++++++++++++++----
> server.c | 6 +++--
> stat.c | 32 ++++++++++++++----------
> 8 files changed, 200 insertions(+), 65 deletions(-)
>
Applied. Thanks.
prev parent reply other threads:[~2024-01-25 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240125054350epcas5p3b4116e69a99e57421c5c22989e5cfb7a@epcas5p3.samsung.com>
2024-01-25 11:01 ` [PATCH v3 0/2] log both average and max values over the window Ankit Kumar
[not found] ` <CGME20240125054351epcas5p3d0cd3a76619116d48afa73da0d88e38d@epcas5p3.samsung.com>
2024-01-25 11:01 ` [PATCH v3 1/2] stat: log out both average and max " Ankit Kumar
[not found] ` <CGME20240125054352epcas5p27caba875a26bd7a0427c1ffc791eae5b@epcas5p2.samsung.com>
2024-01-25 11:01 ` [PATCH v3 2/2] docs: update fio man page for log_window_value Ankit Kumar
2024-01-25 14:11 ` Vincent Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2830529c-c441-4047-8bf5-02698d3fbb05@gmail.com \
--to=vincentfu@gmail.com \
--cc=ankit.kumar@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).