From: Ankit Kumar <ankit.kumar@samsung.com>
To: Vincent Fu <vincentfu@gmail.com>, axboe@kernel.dk
Cc: fio@vger.kernel.org, joshi.k@samsung.com, anuj20.g@samsung.com
Subject: Re: [PATCH v2 0/2] io_uring_cmd cleanup and fixes
Date: Tue, 16 May 2023 18:07:44 +0530 [thread overview]
Message-ID: <20230516123744.GA28572@unvme-desktop> (raw)
In-Reply-To: <b2cb9f09-0475-6722-ea89-6b7fa12a4bf2@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
On Mon, May 15, 2023 at 08:49:54AM -0400, Vincent Fu wrote:
> On 5/15/23 07:03, Ankit Kumar wrote:
> > The NVM command set specification 1.0c supports 64 LBA formats.
> > The first patch adds support for that.
> >
> > The io_uring_cmd ioengine assumes that logical block size is always
> > power of 2. But with namespace formats where metadata is transferred
> > at the end of logical block i.e. an extended logical block this is
> > not true.
> > This second patch adds the support for extended logical block sizes.
> > This however doesn't include support for protection info and metadata
> > transferred as separate buffer, we return error for those.
> >
> > Changes from v1:
> > * Split the original patch into 2 as suggested by Vincent and Jens
> > * Address all review comments from Vincent
> >
> > Ankit Kumar (2):
> > engines/nvme: support for 64 LBA formats
> > engines/io_uring: io_uring_cmd engine fixes
> >
> > engines/io_uring.c | 30 ++++++++++++++++++---
> > engines/nvme.c | 66 ++++++++++++++++++++++++++++++++++++++--------
> > engines/nvme.h | 6 ++---
> > 3 files changed, 84 insertions(+), 18 deletions(-)
> >
>
> Applied with a change to the title of the second patch's commit message.
> Thanks.
>
> Vincent
>
Thanks,
I was wondering if extended LBA changes are required for t/io_uring,
as its part of fast path, and any branching introduced because of
lba_shift and lba_ext may have an impact on performace.
Ankit
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2023-05-16 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230515054350epcas5p4643d68a6f79cae867b88be678154329b@epcas5p4.samsung.com>
2023-05-15 11:03 ` [PATCH v2 0/2] io_uring_cmd cleanup and fixes Ankit Kumar
[not found] ` <CGME20230515054351epcas5p1f2922cc8507e9e6a57bb0228914ff0bc@epcas5p1.samsung.com>
2023-05-15 11:03 ` [PATCH v2 1/2] engines/nvme: support for 64 LBA formats Ankit Kumar
[not found] ` <CGME20230515054352epcas5p15ceded12f770df07d842f324f1ef7857@epcas5p1.samsung.com>
2023-05-15 11:03 ` [PATCH v2 2/2] engines/io_uring: io_uring_cmd engine fixes Ankit Kumar
2023-05-15 12:49 ` [PATCH v2 0/2] io_uring_cmd cleanup and fixes Vincent Fu
2023-05-16 12:37 ` Ankit Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516123744.GA28572@unvme-desktop \
--to=ankit.kumar@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).