From: Jens Axboe <axboe@kernel.dk>
To: fio@vger.kernel.org, Vincent Fu <vincentfu@gmail.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] backend: clear IO_U_F_FLIGHT flag in zero byte read path
Date: Fri, 21 Jul 2023 08:03:22 -0600 [thread overview]
Message-ID: <168994820261.203357.13680760455731904486.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230721044444.749537-1-shinichiro.kawasaki@wdc.com>
On Fri, 21 Jul 2023 13:44:44 +0900, Shin'ichiro Kawasaki wrote:
> When read io_u completes with zero byte read, it sets EIO as the error
> and put the io_u. However, it does not clear the IO_U_F_FLIGHT flag.
> When fio runs with --ignore_error=EIO option, the io_u with the flag is
> reused for next I/O and causes an assertion failure:
>
> fio: ioengines.c:335: td_io_queue: Assertion `(io_u->flags & IO_U_F_FLIGHT) == 0' failed.
>
> [...]
Applied, thanks!
[1/1] backend: clear IO_U_F_FLIGHT flag in zero byte read path
commit: fc37e3dedee9026a4e745c7ab03ed293cb04eb60
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-07-21 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 4:44 [PATCH] backend: clear IO_U_F_FLIGHT flag in zero byte read path Shin'ichiro Kawasaki
2023-07-21 14:03 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168994820261.203357.13680760455731904486.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).